Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15190

Fix ip_diffim FutureWarning

    XMLWordPrintable

    Details

    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      AP F18-2
    • Team:
      Alert Production

      Description

      After upgrading to numpy 1.14, `lsst.ip.diffim.dipoleFitTask` raises a new error:

      python/lsst/ip/diffim/dipoleFitTask.py:303: FutureWarning: `rcond` parameter will change to the default of machine precision times ``max(M, N)`` where M and N are the input matrix dimensions.
      		 
      To use the future default and silence this warning we advise to pass `rcond=None`, to keep using the old, explicitly pass `rcond=-1`.

      It was suggested by Jim Bosch that we simply set `rcond=-1`.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14699 Silence NumPy FutureWarnings in meas_deblender

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13218 rcond future warning in meas_deblender

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            sullivan Ian Sullivan created issue -
            sullivan Ian Sullivan made changes -
            Field Original Value New Value
            Epic Link DM-10068 [ 31628 ]
            sullivan Ian Sullivan made changes -
            Risk Score 1
            tjenness Tim Jenness made changes -
            Link This issue is triggered by DM-13218 [ DM-13218 ]
            tjenness Tim Jenness made changes -
            Link This issue is triggered by DM-14699 [ DM-14699 ]
            sullivan Ian Sullivan made changes -
            Reviewers Meredith Rawls [ mrawls ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            sullivan Ian Sullivan made changes -
            Risk Score 1 0
            Hide
            Permalink
            mrawls Meredith Rawls added a comment -

            Seems reasonable and explicitly preserves the old behavior. Thanks for the quick fix!

             

            Show
            mrawls Meredith Rawls added a comment - Seems reasonable and explicitly preserves the old behavior. Thanks for the quick fix!  
            mrawls Meredith Rawls made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            sullivan Ian Sullivan made changes -
            Sprint AP F18-2 [ 747 ]
            sullivan Ian Sullivan made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            swinbank John Swinbank made changes -
            Epic Link DM-10068 [ 31628 ] DM-14447 [ 80385 ]

              People

              Assignee:
              sullivan Ian Sullivan
              Reporter:
              sullivan Ian Sullivan
              Reviewers:
              Meredith Rawls
              Watchers:
              Ian Sullivan, Jim Bosch, John Swinbank, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.