Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15208

validate_drp skipTEx is being ignored

    XMLWordPrintable

    Details

    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      AP F18-2
    • Team:
      Alert Production

      Description

      During the port to the verify system, support for the skipTEx option was broken in matchreduce.py (it was permanently set to False).

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-12253 Port validate_drp to lsst.verify

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Also, it looks like validate_drp is quite far from flake8 compliance.

            Show
            Parejkoj John Parejko added a comment - Also, it looks like validate_drp is quite far from flake8 compliance.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Simon Krughoff, can you please review this tiny change?

            Should I auto-flake8 validate_drp as part of this too, or do you want to do it?

            Show
            Parejkoj John Parejko added a comment - Simon Krughoff , can you please review this tiny change? Should I auto-flake8 validate_drp as part of this too, or do you want to do it?
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Looks OK. A few minor questions and suggestions on the pull request.

            Show
            rowen Russell Owen added a comment - - edited Looks OK. A few minor questions and suggestions on the pull request.
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            Jenkins run post-review: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28281/pipeline

            Show
            Parejkoj John Parejko added a comment - - edited Jenkins run post-review: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28281/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thank you for the expedited review, Russell Owen.

            The jenkins run found one bug involving sqlite exceptions (also introduced during the verify port; apparently DM-12977 wasn't carried forward?), which I've re-fixed.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thank you for the expedited review, Russell Owen . The jenkins run found one bug involving sqlite exceptions (also introduced during the verify port; apparently DM-12977 wasn't carried forward?), which I've re-fixed. Merged and done.
            Hide
            Permalink
            wmwood-vasey Michael Wood-Vasey added a comment -

            Thanks, John Parejko !

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - Thanks, John Parejko !

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Russell Owen
              Watchers:
              John Parejko, John Swinbank, Michael Wood-Vasey, Russell Owen, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.