Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: display_firefly
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:SUIT Sprint 2018-08
-
Team:Science User Interface
Description
When using afw.display with the Firefly backend, writing ellipses with buffering does not draw ellipses:
with display.Buffering():
|
for record in src256[::10]: |
display.dot(record.getShape(), record.getX(), record.getY())
|
It works without the buffering.
Attachments
Issue Links
- is triggering
-
- Done
Activity
David Shupe
created issue -
David Shupe
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Risk Score | 0 |
David Shupe
made changes -
| Watchers | Cindy Wang, David Shupe, Trey Roby, Xiuqin Wu [ Cindy Wang, David Shupe, Trey Roby, Xiuqin Wu ] | Cindy Wang, David Shupe, Robert Lupton, Trey Roby, Xiuqin Wu [ Cindy Wang, David Shupe, Robert Lupton, Trey Roby, Xiuqin Wu ] |
Questions for Robert Lupton: Should afw.display.dot check for NaNs in the ellipse shape parameters and refrain from sending them?
When a backend receives an ellipse with NaN shape parameters, is it sufficient to silently ignore these? Or should some sort of error be communicated back to the user?
David Shupe
added a comment - Questions for Robert Lupton : Should afw.display.dot check for NaNs in the ellipse shape parameters and refrain from sending them?
When a backend receives an ellipse with NaN shape parameters, is it sufficient to silently ignore these? Or should some sort of error be communicated back to the user? I think you can silently ignore NaNs – they aren't the display code's problem.
| Epic Link |
|
It is a bug in Firefly. Firefly intends to ignore nani silently and render other correct ones based on current development.
The bug in Firefly has been fixed in DM-15245.
No action is needed on the Python side. Ellipses with NaN shapes are silently discarded by the backend.
The story points are for analyzing the problem and testing.
David Shupe
added a comment - The bug in Firefly has been fixed in DM-15245 .
No action is needed on the Python side. Ellipses with NaN shapes are silently discarded by the backend.
The story points are for analyzing the problem and testing. David Shupe
made changes -
| Resolution | Done [ 10000 ] | |
| Status | To Do [ 10001 ] | Done [ 10002 ] |
David Shupe
made changes -
| Sprint | SUIT Sprint 2018-08 [ 738 ] |
NaN values in the catalog cause the problems. When not buffering, the regions are sent individually and the valid ellipses are drawn. When buffering is on, the regions are sent all at once and the NaN-shape ones cause all the regions to fail.