Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15220

Moving SuperTask to pipe_base

    XMLWordPrintable

Details

    Description

      We have ~agreed on a better name for SuperTask class, PipelineTask looks like a better one for everyone. We should rename the class and move it to pipe_base in preparation to merging all gen3 stuff with master.

      Attachments

        Issue Links

          Activity

            Tim, as you have already started looking at it and finding issues, will you have time to complete the review? All unit tests are OK, and QuantumGraph building works as before.

            salnikov Andy Salnikov added a comment - Tim, as you have already started looking at it and finding issues, will you have time to complete the review? All unit tests are OK, and QuantumGraph building works as before.
            jbosch Jim Bosch added a comment -

            We should probably do an RFC before merging this.  I'll do that today, and hope that a short RFC (closing Friday) is better than none (so we still have the goal of getting gen3-middleware on master this Friday).  Does that work for everyone?

             

            jbosch Jim Bosch added a comment - We should probably do an RFC before merging this.  I'll do that today, and hope that a short RFC (closing Friday) is better than none (so we still have the goal of getting gen3-middleware on master this Friday).  Does that work for everyone?  

            For the record: I think this is a good renaming.

            gpdf Gregory Dubois-Felsmann added a comment - For the record: I think this is a good renaming.

            Jim, sounds OK for me. I'll try to get DM-14823 ready by Friday too (it's interface change so we should do it sooner) if we can decide on one of the options there.

            salnikov Andy Salnikov added a comment - Jim, sounds OK for me. I'll try to get  DM-14823 ready by Friday too (it's interface change so we should do it sooner) if we can decide on one of the options there.
            tjenness Tim Jenness added a comment -

            I have not looked at the code but the renaming looks fine.

            tjenness Tim Jenness added a comment - I have not looked at the code but the renaming looks fine.

            Jenkins centos jobs completed, osx is still running bit Tim said it's OK to merge (osx seems to be very slow). Merged both packages, done.

            salnikov Andy Salnikov added a comment - Jenkins centos jobs completed, osx is still running bit Tim said it's OK to merge (osx seems to be very slow). Merged both packages, done.

            People

              salnikov Andy Salnikov
              salnikov Andy Salnikov
              Tim Jenness
              Andy Salnikov, Gregory Dubois-Felsmann, Jim Bosch, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.