Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Team:DM Science
Description
There are a few minor bugs to do with using showCamera to display raw and calibration frames such as biases. Additionally the code to handle calexps was fragile, as was the handling of cameras for which ccd=ccd.getId() is an invalid dataId field.
Please fix them.
Attachments
Activity
As we discussed, these are misc bug fixes that never got committed.
I assume you're asking for a review of https://github.com/lsst/afw/pull/375 — is there anything else covered by this ticket?
That's all. Easy!
The mechanics of the code itself looks fine. A couple of minor comments on the PR.
This module as a whole could use more explanation of what it's actually supposed to do — it's hard to judge whether this is actually going to perform as advertised when there's no advertisement. I don't think this change makes that significantly worse, though, and I don't think it's reasonable to ask you to provide rationale for the whole file on this ticket. Might be helpful to add a comment on why you're forcing allowRotate to False at line 496.
Addressed comments, merged to master, pushed, fixed flake8 pickiness, pushed.
In afw or obs_subaru (or both)?
Is it possible to be more specific than “a few minor bugs”?