Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15241

log error when final chi2 is large

    XMLWordPrintable

    Details

      Description

      For some reason, PDR1 tract 15832 HSC-Y got a chi2/ndof of 827 for astrometry, with validate_drp agreeing that the fit was poor, but no obvious "this fit might have trouble" message was logged. We should log an error message for all jointcal final fit results that have chi2/ndof >= X, where X might be 5 or 10 (as a first guess at "possibly bad" chi2).

        Attachments

          Issue Links

          is triggering

          Improvement - An improvement or enhancement to an existing feature or task. DM-15247 "goodness of fit" criterion for jointcal

          • To Do
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-25159 Have jointcal fail if the chi2 increases dramatically between steps

          • Done

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-11783 Replace meas_mosaic with Jointcal

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Meredith Rawls: do you mind doing this small review? It's almost all new tests, plus the minor code change requested by this ticket. You can learn how to mock things from it!

            Show
            Parejkoj John Parejko added a comment - Meredith Rawls : do you mind doing this small review? It's almost all new tests, plus the minor code change requested by this ticket. You can learn how to mock things from it!
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28290/pipeline

            Show
            Parejkoj John Parejko added a comment - Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28290/pipeline
            Hide
            Permalink
            mrawls Meredith Rawls added a comment -

            I think this looks good, but I asked for some clarifications on the new test over on GitHub. Assuming those are easily resolved/answered, I'm happy with you merging this.

            Show
            mrawls Meredith Rawls added a comment - I think this looks good, but I asked for some clarifications on the new test over on GitHub. Assuming those are easily resolved/answered, I'm happy with you merging this.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thank you for the review. I responded to your questions and added some comments and another assert.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thank you for the review. I responded to your questions and added some comments and another assert. Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Meredith Rawls
              Watchers:
              Dominique Boutigny, Hsin-Fang Chiang, Jim Bosch, John Parejko, John Swinbank, Lauren MacArthur, Meredith Rawls, Pierre Astier
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.