Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: afw
-
Labels:
-
Story Points:5
-
Epic Link:
-
Sprint:AP F18-2
-
Team:Alert Production
Description
Change fluxSigma to fluxErr, apCorrSigma to apCorrErr and similarly for the diagonal elements of covariance matrices. This includes variable names, argument names and afw table field names. This is necessary in order to implement RFC-333.
Change afw::table::CovarianceMatrixKey to use "Err" as a suffix rather than "Sigma".
Update the FITS catalog persistence as follows:
- Bump the schema VERSION constant from 1 to 2 in SchemaImpl.h
- When reading version 1 catalogs make a fooErr as an alias to every fooSigma field
- When reading version 0 catalogs make Err aliases instead of Sigma aliases.
Attachments
Issue Links
- blocks
-
DM-8828 Support proper motions in reference catalogs
- Done
- duplicates
-
- Won't Fix
- is triggered by
-
- Implemented
- is triggering
-
DM-15355 ci_hsc failure: aperture correction fields for PsfFlux not present
- Done
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Risk Score | 0 |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Summary | Add support for "Err" suffix to CovarianceMatrixKey | Change CovarianceMatrixKey field name suffix from Sigma to Err |
| Description |
{{afw::table::CovarianceMatrixKey}} should support "Err" as a suffix, as well as "Sigma". This is necessary in order to implement Simply allowing this suffix to be specified is probably trivial. However, for backwards compatibility it would be nice if we could read existing persisted tables with "Sigma" suffix as "Err", but I have no idea how practical that is. [~jbosch] do you have any ideas about this? My initial estimate of story points is based on either not implementing backwards compatibility or having it be fairly easy. |
{{afw::table::CovarianceMatrixKey}} should use "Err" instead of "Sigma" as its field name suffix for diagonal elements. This is necessary in order to implement Update the VERSION in SchemaImpl.h and add code that handles older catalogs. |
| Description |
{{afw::table::CovarianceMatrixKey}} should use "Err" instead of "Sigma" as its field name suffix for diagonal elements. This is necessary in order to implement Update the VERSION in SchemaImpl.h and add code that handles older catalogs. |
{{afw::table::CovarianceMatrixKey}} should support "Err" as a suffix, as well as "Sigma". This is necessary in order to implement Simply allowing this suffix to be specified is probably trivial. However, for backwards compatibility it would be nice if we could read existing persisted tables with "Sigma" suffix as "Err", but I have no idea how practical that is. [~jbosch] do you have any ideas about this? My initial estimate of story points is based on either not implementing backwards compatibility or having it be fairly easy. I also see that DM- |
| Story Points | 2 | 5 |
| Summary | Change CovarianceMatrixKey field name suffix from Sigma to Err | Change fluxSigma to fluxErr and similarly for covariances |
| Description |
{{afw::table::CovarianceMatrixKey}} should support "Err" as a suffix, as well as "Sigma". This is necessary in order to implement Simply allowing this suffix to be specified is probably trivial. However, for backwards compatibility it would be nice if we could read existing persisted tables with "Sigma" suffix as "Err", but I have no idea how practical that is. [~jbosch] do you have any ideas about this? My initial estimate of story points is based on either not implementing backwards compatibility or having it be fairly easy. I also see that DM- |
Change fluxSigma to fluxErr, apCorrSigma to apCorrErr and similarly for the diagonal elements of covariance matrices. This includes variable names, argument names and afw table field names. This is necessary in order to implement Change {{afw::table::CovarianceMatrixKey}} to use "Err" as a suffix rather than "Sigma". Update the FITS catalog persistence as follows: - Bump the schema VERSION constant from 1 to 2 in SchemaImpl.h - When reading version 1 catalogs make a {{fooErr}} as an alias to every {{fooSigma}} field - When reading version 0 catalogs make {{Err}} aliases instead of {{Sigma}} aliases. |
| Summary | Change fluxSigma to fluxErr and similarly for covariances | Change fluxSigma to fluxErr and similarly for apCorr and covariances |
| Reviewers | Jim Bosch [ jbosch ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
| Reviewers | Jim Bosch [ jbosch ] | Jim Bosch, Sophie Reed [ jbosch, sophiereed ] |
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |