Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15245

bug fix in regions API: draw the correct regions, discard the wrong ones

    XMLWordPrintable

Details

    • Bug
    • Status: Done
    • Resolution: Done
    • None
    • display_firefly
    • None

    Description

      DM-15213 is fixing the bug in Python  calling function for LSST. We need also to fix it in the JS API. 

      I checked region file upload in current dev version. The non-parsable regions are ignore already in UI.  API should behave the same. 

       

      Attachments

        Issue Links

          Activity

            No builds found.
            xiuqin Xiuqin Wu [X] (Inactive) created issue -
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Field Original Value New Value
            Link This issue clones DM-15213 [ DM-15213 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Assignee David Shupe [ shupe ] Cindy Wang [ cwang ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Summary CLONE - display.dot of ellipses fails with display_firefly when buffering bug fix in regions API: draw the correct regions, discard the wrong ones
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Description When using {{afw.display}} with the Firefly backend, writing ellipses with buffering does not draw ellipses:
             
            {code:python}
            with display.Buffering():
                for record in src256[::10]:
                    display.dot(record.getShape(), record.getX(), record.getY())
            {code}

            It works without the buffering.
            DM-15213 is fixing the bug in Python  calling function for LSST. We need also to fix it in the JS API. 

            I checked region file upload in current dev version. The non-parsable regions are ignore already in UI. This need to be done in the API too. 

            It works without the buffering.
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Description DM-15213 is fixing the bug in Python  calling function for LSST. We need also to fix it in the JS API. 

            I checked region file upload in current dev version. The non-parsable regions are ignore already in UI. This need to be done in the API too. 

            It works without the buffering.
            DM-15213 is fixing the bug in Python  calling function for LSST. We need also to fix it in the JS API. 

            I checked region file upload in current dev version. The non-parsable regions are ignore already in UI.  API should behave the same. 

             
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Epic Link DM-13639 [ 38989 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2018-09 [ 739 ]
            cwang Cindy Wang [X] (Inactive) made changes -
            Sprint SUIT Sprint 2018-09 [ 739 ] SUIT Sprint 2018-08 [ 738 ]
            cwang Cindy Wang [X] (Inactive) made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            cwang Cindy Wang [X] (Inactive) made changes -
            Reviewers David Shupe, Tatiana Goldina [ shupe, tatianag ]
            Status In Progress [ 3 ] In Review [ 10004 ]

            API uses the region parser done by JS code. It intends to skip the region with wrong description silently and render other regions with good description. It is a bug in the region parser of JS code causing the issue. 

            cwang Cindy Wang [X] (Inactive) added a comment - - edited API uses the region parser done by JS code. It intends to skip the region with wrong description silently and render other regions with good description. It is a bug in the region parser of JS code causing the issue. 
            cwang Cindy Wang [X] (Inactive) made changes -
            Remote Link This issue links to "pull request (Web Link)" [ 17801 ]
            tatianag Tatiana Goldina made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            cwang Cindy Wang [X] (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Link This issue is triggered by DM-15213 [ DM-15213 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Link This issue clones DM-15213 [ DM-15213 ]

            People

              cwang Cindy Wang [X] (Inactive)
              shupe David Shupe
              David Shupe, Tatiana Goldina
              Cindy Wang [X] (Inactive), David Shupe, Tatiana Goldina, Trey Roby, Xiuqin Wu [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.