Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15276

Unify DataUnitRegion and DataUnitJoin

    XMLWordPrintable

Details

    • 2
    • DRP F18-2
    • Data Release Production

    Description

      Right now DataUnitRegion and DataUnitJoin are two separate, but roughly similar objects.
      Unify them, potentially also adding a base-class or mix-in for things they have in common with DataUnit.

      Attachments

        Issue Links

          Activity

            Was done together with pschella

            pschella Pim Schellart [X] (Inactive) added a comment - Was done together with pschella

            Hi Andy, please take a look at this. There was one special case with preflight when this was merged. Hope the comment is clear.

            pschella Pim Schellart [X] (Inactive) added a comment - Hi Andy, please take a look at this. There was one special case with preflight when this was merged. Hope the comment is clear.

            (I think Jira links incorrect PR, I looked at https://github.com/lsst/daf_butler/pull/66 just in case)

            Looks OK to me, few minor comments left on PR. Preflight comment is clear (after I read it 5 times and tried to remember what preflight does there )

            salnikov Andy Salnikov added a comment - (I think Jira links incorrect PR, I looked at https://github.com/lsst/daf_butler/pull/66  just in case) Looks OK to me, few minor comments left on PR. Preflight comment is clear (after I read it 5 times and tried to remember what preflight does there  )

            Stealing this back from czw and wrapping it up. Was very much joint effort.

            pschella Pim Schellart [X] (Inactive) added a comment - - edited Stealing this back from czw and wrapping it up. Was very much joint effort.
            cwalter Chris Walter added a comment -

            Umm... I apparently have been sleep coding

            Do you mean to @ someone else?

             

             

            cwalter Chris Walter added a comment - Umm... I apparently have been sleep coding Do you mean to @ someone else?    
            jbosch Jim Bosch added a comment -

            The first of many Waters/Walters bad-@s.

            jbosch Jim Bosch added a comment - The first of many Waters/Walters bad-@s.

            People

              pschella Pim Schellart [X] (Inactive)
              pschella Pim Schellart [X] (Inactive)
              Andy Salnikov
              Andy Salnikov, Chris Walter, Jim Bosch, Pim Schellart [X] (Inactive), Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.