Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15323

Adapt validate_drp for new obs_lsstCam

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: validate_drp
    • Labels:
      None

      Description

      Adapt validate_drp to run on new obs_lsstCam package.

      1. [x] Add 'detector' to list of CCD names in validate_drp.utli.getCcdKeyName
      2. [x] Check that this works through running on obs_lsstCam data, which

      I think that's it.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          wmwood-vasey Michael Wood-Vasey created issue -
          wmwood-vasey Michael Wood-Vasey made changes -
          Field Original Value New Value
          Epic Link DM-14871 [ 130021 ]
          wmwood-vasey Michael Wood-Vasey made changes -
          Risk Score 0
          Hide
          Permalink
          wmwood-vasey Michael Wood-Vasey added a comment -

          Quick review.

          This is a trivial one-line change to add 'detector' to the list of equivalent Ccd Key Names to the code in validate_drp loading that needs to figure out how to assign a unique integer identifier to the object send to multiMatch. The new obs_lsstCam packages makes this easy with the detector name. I just added that along with the 'ccd', 'ccdname', 'camcol', etc.

          I used this to analyze DESC Data Challenge 2 Run-1.2p-test data and it works there.

          It passes Jenkins (which doesn't actually have any test that would use 'detector' explicitly, but at least it doesn't break existing things):

          https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28316/pipeline

          Show
          wmwood-vasey Michael Wood-Vasey added a comment - Quick review. This is a trivial one-line change to add 'detector' to the list of equivalent Ccd Key Names to the code in validate_drp loading that needs to figure out how to assign a unique integer identifier to the object send to multiMatch. The new obs_lsstCam packages makes this easy with the detector name. I just added that along with the 'ccd', 'ccdname', 'camcol', etc. I used this to analyze DESC Data Challenge 2 Run-1.2p-test data and it works there. It passes Jenkins (which doesn't actually have any test that would use 'detector' explicitly, but at least it doesn't break existing things): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28316/pipeline
          wmwood-vasey Michael Wood-Vasey made changes -
          Status To Do [ 10001 ] In Review [ 10004 ]
          Hide
          Permalink
          krughoff Simon Krughoff added a comment -

          Looks good.

          Show
          krughoff Simon Krughoff added a comment - Looks good.
          krughoff Simon Krughoff made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Hide
          Permalink
          wmwood-vasey Michael Wood-Vasey added a comment -

          Merged to master.

          Thanks for the quick review!

          Show
          wmwood-vasey Michael Wood-Vasey added a comment - Merged to master. Thanks for the quick review!
          wmwood-vasey Michael Wood-Vasey made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          wmwood-vasey Michael Wood-Vasey made changes -
          Description Adapt validate_drp to run on new obs_lsstCam package.

          1. [ ] Add 'detector' to list of CCD names in {{validate_drp.utli.getCcdKeyName}}
          2. [ ] Chack that this works through running on obs_lsstCam data, which

          I think that's it.           		Adapt validate_drp to run on new obs_lsstCam package.

          1. [x] Add 'detector' to list of CCD names in {{validate_drp.utli.getCcdKeyName}}
          2. [x] Check that this works through running on obs_lsstCam data, which

          I think that's it.

            People

            Assignee:
            wmwood-vasey Michael Wood-Vasey
            Reporter:
            wmwood-vasey Michael Wood-Vasey
            Reviewers:
            Simon Krughoff
            Watchers:
            Michael Wood-Vasey, Simon Krughoff
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.