Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15323

Adapt validate_drp for new obs_lsstCam

    XMLWordPrintable

Details

    • Bug
    • Status: Done
    • Resolution: Done
    • None
    • validate_drp
    • None

    Description

      Adapt validate_drp to run on new obs_lsstCam package.

      1. [x] Add 'detector' to list of CCD names in validate_drp.utli.getCcdKeyName
      2. [x] Check that this works through running on obs_lsstCam data, which

      I think that's it.

      Attachments

        Activity

          Quick review.

          This is a trivial one-line change to add 'detector' to the list of equivalent Ccd Key Names to the code in validate_drp loading that needs to figure out how to assign a unique integer identifier to the object send to multiMatch. The new obs_lsstCam packages makes this easy with the detector name. I just added that along with the 'ccd', 'ccdname', 'camcol', etc.

          I used this to analyze DESC Data Challenge 2 Run-1.2p-test data and it works there.

          It passes Jenkins (which doesn't actually have any test that would use 'detector' explicitly, but at least it doesn't break existing things):

          https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28316/pipeline

          wmwood-vasey Michael Wood-Vasey added a comment - Quick review. This is a trivial one-line change to add 'detector' to the list of equivalent Ccd Key Names to the code in validate_drp loading that needs to figure out how to assign a unique integer identifier to the object send to multiMatch. The new obs_lsstCam packages makes this easy with the detector name. I just added that along with the 'ccd', 'ccdname', 'camcol', etc. I used this to analyze DESC Data Challenge 2 Run-1.2p-test data and it works there. It passes Jenkins (which doesn't actually have any test that would use 'detector' explicitly, but at least it doesn't break existing things): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28316/pipeline

          Looks good.

          krughoff Simon Krughoff (Inactive) added a comment - Looks good.

          Merged to master.

          Thanks for the quick review!

          wmwood-vasey Michael Wood-Vasey added a comment - Merged to master. Thanks for the quick review!

          People

            wmwood-vasey Michael Wood-Vasey
            wmwood-vasey Michael Wood-Vasey
            Simon Krughoff (Inactive)
            Michael Wood-Vasey, Simon Krughoff (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.