Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: pipe_base
-
Labels:None
-
Team:DM Science
Description
Docs claim it supports globs; it doesn't.
--show history=*do* gives:
Error: config has no field *do*
which, for processCcd.py is clearly wrong.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Risk Score | 0 |
Paul Price
made changes -
| Description |
Docs claim it supports globs; it doesn't.
{{--show history=*do*}} gives: {{Error: config has no field *do*}} which, for {{processCcd.py}} is clearly wrong. |
Docs claim it supports globs; it doesn't.
{{\-\-show history=\*do\*}} gives: {{Error: config has no field \*do\*}} which, for {{processCcd.py}} is clearly wrong. |
Changes in pex_config and pipe_base
| Reviewers | Merlin Fisher-Levine [ mfisherlevine ] | |
| Status | To Do [ 10001 ] | In Review [ 10004 ] |
| Team | DM Science [ 12218 ] |
Not being very familiar with this part of the codebase it's not that obvious how this works, but assuming it does it looks OK to me, other than the one comment about the line length of the comment being too long. And normally I wouldn't be so picky, but I believe that's going to stop builds working soon, so best not to add more places where that rule is broken.
I take it you've run this through Jenkins etc? Assuming so, it's good to merge once you fix that comment length 
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
Fixed the long line (although why comments don't follow the same rules as all other code I don't know – I sort-of understand the argument for doc strings).
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
(poor benighted tcsh users will have to quote the {{*}}s)