Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15328

--show history doesn't support globs

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • pipe_base
    • None
    • DM Science

    Description

      Docs claim it supports globs; it doesn't.

      --show history=*do* gives:
      Error: config has no field *do*
      which, for processCcd.py is clearly wrong.

      Attachments

        Activity

          (poor benighted tcsh users will have to quote the {{*}}s)

          rhl Robert Lupton added a comment - (poor benighted tcsh users will have to quote the {{*}}s)

          Changes in pex_config and pipe_base

          rhl Robert Lupton added a comment - Changes in pex_config and pipe_base

          Not being very familiar with this part of the codebase it's not that obvious how this works, but assuming it does it looks OK to me, other than the one comment about the line length of the comment being too long. And normally I wouldn't be so picky, but I believe that's going to stop builds working soon, so best not to add more places where that rule is broken.

          I take it you've run this through Jenkins etc? Assuming so, it's good to merge once you fix that comment length

          mfisherlevine Merlin Fisher-Levine added a comment - Not being very familiar with this part of the codebase it's not that obvious how this works, but assuming it does it looks OK to me, other than the one comment about the line length of the comment being too long. And normally I wouldn't be so picky, but I believe that's going to stop builds working soon, so best not to add more places where that rule is broken. I take it you've run this through Jenkins etc? Assuming so, it's good to merge once you fix that comment length

          Fixed the long line (although why comments don't follow the same rules as all other code I don't know – I sort-of understand the argument for doc strings).

          rhl Robert Lupton added a comment - Fixed the long line (although why comments don't follow the same rules as all other code I don't know – I sort-of understand the argument for doc strings).

          People

            rhl Robert Lupton
            mfisherlevine Merlin Fisher-Levine
            Merlin Fisher-Levine
            Merlin Fisher-Levine, Robert Lupton
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.