Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: display_firefly
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:SUIT Sprint 2018-08
-
Team:Science User Interface
Description
To improve performance of image display in Firefly, allow an afwDisplay instance with the Firefly backend to track display.scale and display.pan settings that precede display.mtv, and apply these at the time of image display. Also add a small correction to the pan method so that it uses the LSST pixel coordinate convention.
Implemented:
Modify the display_firefly backend to remember the results of scale (stretch) commands, and to apply scale and pan parameters when displaying an image with lsst.afw.display.mtv.
- Remember and apply the serialized RangeValues string that Firefly uses
- Correct pan command by 0.5 pixels to follow LSST convention
- Apply the remembered pan position when using mtv
- Make 'slate.html' the default if it is not passed explicitly or if the environment variable FIREFLY_HTML is not defined. This is necessary for Firefly to show readout of LSST pixel convention.
Attachments
Issue Links
Activity
David Shupe
created issue -
David Shupe
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
David Shupe
made changes -
David Shupe
made changes -
| Risk Score | 0 |
David Shupe
made changes -
David Shupe
made changes -
David Shupe
made changes -
| Description | To improve performance of image display in Firefly, allow an afwDisplay instance with the Firefly backend to track {{display.scale}} and {{display.pan}} settings that precede {{display.mtv}}, and apply these at the time of image display. | To improve performance of image display in Firefly, allow an afwDisplay instance with the Firefly backend to track {{display.scale}} and {{display.pan}} settings that precede {{display.mtv}}, and apply these at the time of image display. Also add a small correction to the pan method so that it uses the LSST pixel coordinate convention. |
David Shupe
made changes -
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
David Shupe
made changes -
| Remote Link | This issue links to "firefly_client pull request (Web Link)" [ 17817 ] |
David Shupe
made changes -
| Reviewers | Tatiana Goldina [ tatianag ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Description | To improve performance of image display in Firefly, allow an afwDisplay instance with the Firefly backend to track {{display.scale}} and {{display.pan}} settings that precede {{display.mtv}}, and apply these at the time of image display. Also add a small correction to the pan method so that it uses the LSST pixel coordinate convention. |
To improve performance of image display in Firefly, allow an afwDisplay instance with the Firefly backend to track {{display.scale}} and {{display.pan}} settings that precede {{display.mtv}}, and apply these at the time of image display. Also add a small correction to the pan method so that it uses the LSST pixel coordinate convention.
Implemented: Modify the {{display_firefly}} backend to remember the results of scale (stretch) commands, and to apply scale and pan parameters when displaying an image with {{lsst.afw.display.mtv}}. * Remember and apply the serialized RangeValues string that Firefly uses * Correct pan command by 0.5 pixels to follow LSST convention * Apply the remembered pan position when using {{mtv}} * Make {{'slate.html'}} the default if it is not passed explicitly or if the environment variable {{FIREFLY_HTML}} is not defined. This is necessary for Firefly to show readout of LSST pixel convention. |
There is a complication to storing the pan position. The afw.display interface subtracts the XY0 point before sending the pan coordinates to the backend, when origin=afwImage.PARENT (the default). If a display is initialized and a pan command is sent before an mtv command, the backend does not know the XY0 point and it pans to the wrong location.
There is not an easy fix for this, except for users to be aware that if they specify the pan position before the mtv, they need to specify origin=afwImage.LOCAL in their pan or zoom command. zoom can take a pan position in addition to the zoom factor.
David Shupe
added a comment - There is a complication to storing the pan position. The afw.display interface subtracts the XY0 point before sending the pan coordinates to the backend, when origin=afwImage.PARENT (the default). If a display is initialized and a pan command is sent before an mtv command, the backend does not know the XY0 point and it pans to the wrong location.
There is not an easy fix for this, except for users to be aware that if they specify the pan position before the mtv , they need to specify origin=afwImage.LOCAL in their pan or zoom command. zoom can take a pan position in addition to the zoom factor. Completed and tested, with the caveat that a pan command before an image display should be made from afw.display with origin=afwImage.LOCAL.
David Shupe
added a comment - Completed and tested, with the caveat that a pan command before an image display should be made from afw.display with origin=afwImage.LOCAL . David Shupe
made changes -
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
Remembering the most recent pan() command was implemented in
DM-14734.