Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: afw
-
Labels:
-
Story Points:1
-
Team:Architecture
Description
When testing Boost 1.68 in DM-15385, afw fails to build almost immediately because of failures in lsstGil.h.
include/lsst/afw/image/lsstGil.h:119:34: error: macro "GIL_DEFINE_BASE_TYPEDEFS" requires 3 arguments, but only 2 given
|
In v1.68 GIL_DEFINE_BASE_TYPEDEFS gains a new argument in the middle:
// B - bits size/signedness, CM - channel model, CS - colour space, LAYOUT - pixel layout
|
// Example: B = '8', CM = 'uint8_t', CS = 'bgr, LAYOUT='bgr_layout_t'
|
...
|
#define GIL_DEFINE_BASE_TYPEDEFS(B, CM, CS) |
This is not documented as a breaking change so I wonder if we are using internal APIs here. The immediate fix would be to add the channel model definition to our header file, but it would be preferable to use a public API if one exists since that might also work for boost 1.66 (that we are currently using).
Attachments
Issue Links
Activity
All tests pass with these changes: https://github.com/lsst/afw/pull/379
Jim Bosch would you mind having a look at this? I think Robert Lupton is too busy.
GIL was added in v1.35 in March 2008 and apart from one warning fix in 2010, the updates in v1.68 seem to be the first time anything has changed since then.