Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15410

measureCrosstalk was broken by the move of crosstalk correction to above assembly

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_isr
    • Labels:
      None
    • Team:
      DM Science

      Description

      When the crosstalk correction code was moved to above CCD assembly the routine extractAmp was changed to work on un-assembled CCDs.  This broke measureCrosstalk (this is hard to fix nicely until DM-15409 is resolved).

      Additionally, measureCrosstalk assumes that you have enough data to constrain all the crosstalk coefficients, and has no way to write the outputs.  Please fix these while you have the package open.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15409 The per-Amplifier flag hasRawInfo is not cleared when the CCD is assembled

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            rhl Robert Lupton created issue -
            rhl Robert Lupton made changes -
            Field Original Value New Value
            Link This issue relates to DM-15409 [ DM-15409 ]
            rhl Robert Lupton made changes -
            Risk Score 0
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            Also please provide a way to write and reuse postISRCCD files.

            Show
            rhl Robert Lupton added a comment - Also please provide a way to write and reuse postISRCCD files.
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            Fixed on master.

            Show
            rhl Robert Lupton added a comment - Fixed on master.
            rhl Robert Lupton made changes -
            Resolution Done [ 10000 ]
            Status To Do [ 10001 ] Done [ 10002 ]
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Robert Lupton — I see this on a branch, but it hasn't made it to master. (And obviously it'd need to be reviewed, etc, before it did.)

            Show
            swinbank John Swinbank added a comment - Robert Lupton — I see this on a branch, but it hasn't made it to master. (And obviously it'd need to be reviewed, etc, before it did.)
            swinbank John Swinbank made changes -
            Resolution Done [ 10000 ]
            Status Done [ 10002 ] In Progress [ 3 ]
            swinbank John Swinbank made changes -
            Team DM Science [ 12218 ]
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            Sorry, that comment applied to an obs_lsstCam change. Yes, I did this on a branch and will put it up for review.

            Show
            rhl Robert Lupton added a comment - Sorry, that comment applied to an obs_lsstCam change. Yes, I did this on a branch and will put it up for review.
            rhl Robert Lupton made changes -
            Reviewers Paul Price [ price ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            price Paul Price added a comment -

            Looks good. I've made a few minor comments on the GitHub PR.

            Show
            price Paul Price added a comment - Looks good. I've made a few minor comments on the GitHub PR.
            price Paul Price made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            Responded to comments, merged, pushed

            Show
            rhl Robert Lupton added a comment - Responded to comments, merged, pushed
            rhl Robert Lupton made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              rhl Robert Lupton
              Reporter:
              rhl Robert Lupton
              Reviewers:
              Paul Price
              Watchers:
              John Swinbank, Paul Price, Robert Lupton
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.