Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15438

display_firefly setMaskTransparency is backwards

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: display_firefly
    • Labels:
      None
    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      SUIT Sprint 2018-08
    • Team:
      Science User Interface

      Description

      setMaskTransparency(100) in display_firefly makes makes mask overlays fully opaque, while the the documention (and the behavior of the same call in display_matplotlib, at least) suggest it should make them fully transparent.

        Attachments

          Issue Links

            Activity

            No builds found.
            jbosch Jim Bosch created issue -
            jbosch Jim Bosch made changes -
            Field Original Value New Value
            Risk Score 0
            Hide
            shupe David Shupe added a comment -

            Thanks Jim Bosch, I implemented opacity instead of transparency. Robert Lupton pointed this out a couple days ago.  I'll make the update and then it will be necessary to update the  with-globular notebook.

            Show
            shupe David Shupe added a comment - Thanks Jim Bosch , I implemented opacity instead of transparency. Robert Lupton pointed this out a couple days ago.  I'll make the update and then it will be necessary to update the   with-globular notebook.
            shupe David Shupe made changes -
            Epic Link DM-8731 [ 28568 ]
            shupe David Shupe made changes -
            Sprint SUIT Sprint 2018-08 [ 738 ]
            Story Points 0.5
            Watchers Jim Bosch [ Jim Bosch ] Cindy Wang, Gregory Dubois-Felsmann, Jim Bosch, Robert Lupton, Tatiana Goldina, Trey Roby, Xiuqin Wu [ Cindy Wang, Gregory Dubois-Felsmann, Jim Bosch, Robert Lupton, Tatiana Goldina, Trey Roby, Xiuqin Wu ]
            Priority Undefined [ 10000 ] Major [ 3 ]
            shupe David Shupe made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            shupe David Shupe added a comment -

            It's a very small change – Firefly uses opacity. I have tested in on lsst-lspdev already.

            Show
            shupe David Shupe added a comment - It's a very small change – Firefly uses opacity. I have tested in on lsst-lspdev already.
            shupe David Shupe made changes -
            Reviewers Jim Bosch [ jbosch ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            jbosch Jim Bosch added a comment -

            Looks good, thanks for the quick fix!

            Show
            jbosch Jim Bosch added a comment - Looks good, thanks for the quick fix!
            jbosch Jim Bosch made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Remote Link This issue links to "Page (Confluence)" [ 17838 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Remote Link This issue links to "Page (Confluence)" [ 17838 ]
            gpdf Gregory Dubois-Felsmann made changes -
            Remote Link This issue links to "Page (Confluence)" [ 17880 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Epic Link DM-8731 [ 28568 ] DM-14499 [ 84664 ]

              People

              Assignee:
              shupe David Shupe
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Jim Bosch
              Watchers:
              Cindy Wang [X] (Inactive), David Shupe, Gregory Dubois-Felsmann, Jim Bosch, Robert Lupton, Tatiana Goldina, Trey Roby, Xiuqin Wu [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.