Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15442

Remove python 2 support to more packages and add pyList=[]

    XMLWordPrintable

    Details

      Description

      For packages with automatic flake8 testing the file tests/SConscript should contain

      from lsst.sconsUtils import scripts
      scripts.BasicSConscript.tests(pyList=[])
      

      but some packages are missing pyList=[] so the tests are not being run

        Attachments

          Activity

          Hide
          rowen Russell Owen added a comment -

          I ended up adding automatic flake8 checking to some packages and removing python 2 support in others as the main work.

          In one case I didn't add pyList=[] at all: meas_extensions_psfEx has some flake8 errors that are bugs and I'm not sure how to fix them (at least some of these have tickets already). Since we are going to retire that package I didn't think it worth spending the time on. But I was able to remove python_future from its ups table file. I probably should have used a different ticket for that, but this one was expedient.

          Show
          rowen Russell Owen added a comment - I ended up adding automatic flake8 checking to some packages and removing python 2 support in others as the main work. In one case I didn't add pyList=[] at all: meas_extensions_psfEx has some flake8 errors that are bugs and I'm not sure how to fix them (at least some of these have tickets already). Since we are going to retire that package I didn't think it worth spending the time on. But I was able to remove python_future from its ups table file. I probably should have used a different ticket for that, but this one was expedient.
          Hide
          tjenness Tim Jenness added a comment -

          Looks great. Thanks.

          Show
          tjenness Tim Jenness added a comment - Looks great. Thanks.
          Hide
          rowen Russell Owen added a comment - - edited

          I made the suggested updates to meas_deblender and required Travis for 3 of the following 4 packages (you had done all the work on one case and most of the work in two others):

          • meas_deblender
          • meas_extensions_photometryKron
          • meas_extensions_shapeHSM
          • validate_drp

          I tried reverting the .travis.yml file changes in validate_drp on a user branch u/rowen/DM-15442 but Travis failed. Perhaps Jonathan Sick will have some ideas of what's going on. The standard file works, but does not try to build sphinx docs.

          Show
          rowen Russell Owen added a comment - - edited I made the suggested updates to meas_deblender and required Travis for 3 of the following 4 packages (you had done all the work on one case and most of the work in two others): meas_deblender meas_extensions_photometryKron meas_extensions_shapeHSM validate_drp I tried reverting the .travis.yml file changes in validate_drp on a user branch u/rowen/ DM-15442 but Travis failed. Perhaps Jonathan Sick will have some ideas of what's going on. The standard file works, but does not try to build sphinx docs.
          Hide
          rowen Russell Owen added a comment -

          Jonathan Sick said (on the github pull request) that the travis sphinx build should indeed be deleted.

          Show
          rowen Russell Owen added a comment - Jonathan Sick said (on the github pull request) that the travis sphinx build should indeed be deleted.

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Tim Jenness
            Watchers:
            Russell Owen, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.