Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15447

Registry fails to fill PatchSkyPixJoin table

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      It looks like DM-15098 introduced regression in the method that populates regions, it looks like regions are added to the Patch table but corresponding PatchSkyPixJoin table is not updated.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15098 Add Registry.getRegion(DataId)

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15459 Make dependencies optional in sets-of-DataUnits lookups

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            Jim Bosch, I have a rather trivial fix for this issue and I have added unit test for it. Jenkins still builds but I verified that ci_hsc now makes correctly filled tables. Pim Schellart [X], you are welcome to check if this patch contradicts grand design of the registry.
            JIRA still has not picked up PR: https://github.com/lsst/daf_butler/pull/74

            Show
            salnikov Andy Salnikov added a comment - Jim Bosch , I have a rather trivial fix for this issue and I have added unit test for it. Jenkins still builds but I verified that ci_hsc now makes correctly filled tables. Pim Schellart [X] , you are welcome to check if this patch contradicts grand design of the registry. JIRA still has not picked up PR: https://github.com/lsst/daf_butler/pull/74
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Review complete.  One comment on the PR.  Thanks for tracking this down!

            Show
            jbosch Jim Bosch added a comment - Review complete.  One comment on the PR.  Thanks for tracking this down!
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            Thanks for review! Updated docstring, merged and done.

            Show
            salnikov Andy Salnikov added a comment - Thanks for review! Updated docstring, merged and done.

              People

              Assignee:
              salnikov Andy Salnikov
              Reporter:
              salnikov Andy Salnikov
              Reviewers:
              Jim Bosch
              Watchers:
              Andy Salnikov, Jim Bosch
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.