Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15447

Registry fails to fill PatchSkyPixJoin table

    XMLWordPrintable

Details

    • Bug
    • Status: Done
    • Resolution: Done
    • None
    • None

    Description

      It looks like DM-15098 introduced regression in the method that populates regions, it looks like regions are added to the Patch table but corresponding PatchSkyPixJoin table is not updated.

      Attachments

        Issue Links

          Activity

            No builds found.
            salnikov Andy Salnikov created issue -
            salnikov Andy Salnikov made changes -
            Field Original Value New Value
            Link This issue relates to DM-15098 [ DM-15098 ]
            salnikov Andy Salnikov made changes -
            Risk Score 0
            salnikov Andy Salnikov made changes -
            Team Data Access and Database [ 10204 ]

            jbosch, I have a rather trivial fix for this issue and I have added unit test for it. Jenkins still builds but I verified that ci_hsc now makes correctly filled tables. pschella, you are welcome to check if this patch contradicts grand design of the registry.
            JIRA still has not picked up PR: https://github.com/lsst/daf_butler/pull/74

            salnikov Andy Salnikov added a comment - jbosch , I have a rather trivial fix for this issue and I have added unit test for it. Jenkins still builds but I verified that ci_hsc now makes correctly filled tables. pschella , you are welcome to check if this patch contradicts grand design of the registry. JIRA still has not picked up PR: https://github.com/lsst/daf_butler/pull/74
            salnikov Andy Salnikov made changes -
            Reviewers Jim Bosch [ jbosch ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            salnikov Andy Salnikov made changes -
            Epic Link DM-14661 [ 106365 ]
            salnikov Andy Salnikov made changes -
            Sprint BG3_F18_08 [ 772 ]
            jbosch Jim Bosch added a comment -

            Review complete.  One comment on the PR.  Thanks for tracking this down!

            jbosch Jim Bosch added a comment - Review complete.  One comment on the PR.  Thanks for tracking this down!
            jbosch Jim Bosch made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]

            Thanks for review! Updated docstring, merged and done.

            salnikov Andy Salnikov added a comment - Thanks for review! Updated docstring, merged and done.
            salnikov Andy Salnikov made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            jbosch Jim Bosch made changes -
            Link This issue relates to DM-15459 [ DM-15459 ]

            People

              salnikov Andy Salnikov
              salnikov Andy Salnikov
              Jim Bosch
              Andy Salnikov, Jim Bosch
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.