Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15458

Qserv does not build with boost 1.68, compiler warnings

    Details

    • Type: Bug
    • Status: Done
    • Priority: Blocker
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None
    • Templates:
    • Story Points:
      1
    • Sprint:
      DB_F18_08
    • Team:
      Data Access and Database

      Description

      Testing qserv with the new boost it fails:

      :::::  [2018-08-17T15:38:55.627988Z] In file included from core/modules/replica/WorkerFindRequest.h:38:0,
      :::::  [2018-08-17T15:38:55.628004Z]                  from core/modules/replica/WorkerFindRequest.cc:24:
      :::::  [2018-08-17T15:38:55.628018Z] core/modules/replica/WorkerRequest.h:267:18: note: candidate: lsst::qserv::replica::WorkerRequest::ErrorContext lsst::qserv::replica::WorkerRequest::reportErrorIf(bool, lsst::qserv::replica::ExtendedCompletionStatus, const string&)
      :::::  [2018-08-17T15:38:55.628034Z]      ErrorContext reportErrorIf(bool condition,
      :::::  [2018-08-17T15:38:55.628049Z]                   ^~~~~~~~~~~~~
      :::::  [2018-08-17T15:38:55.628063Z] core/modules/replica/WorkerRequest.h:267:18: note:   no known conversion for argument 1 from 'boost::system::error_code' to 'bool'
      

      Also, fix compiler warnings for the following (and similar) statements:

      In file included from core/modules/wconfig/WorkerConfig.cc:25:0:
      core/modules/wconfig/WorkerConfig.h:200:18: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
           unsigned int const getPriorityFast() const {
                        ^~~~~
      

      And for this warning as well:

      core/modules/replica/WorkerRequest.cc: In member function 'void lsst::qserv::replica::WorkerRequest::setStatus(const lsst::qserv::util::Lock&, lsst::qserv::replica::WorkerRequest::CompletionStatus, lsst::qserv::replica::ExtendedCompletionStatus)':
      core/modules/replica/WorkerRequest.cc:248:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
                   if (0 == _performance.start_time) _performance.setUpdateStart();
                   ^~
      core/modules/replica/WorkerRequest.cc:250:9: note: here
               case STATUS_SUCCEEDED:
               ^~~~
      

      See https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28425/pipeline/45

        Attachments

          Container Issues

            Issue Links

              Activity

                People

                • Assignee:
                  gapon Igor Gaponenko
                  Reporter:
                  tjenness Tim Jenness
                  Reviewers:
                  Nate Pease
                  Watchers:
                  Fritz Mueller, Igor Gaponenko, Nate Pease, Tim Jenness, Vaikunth Thukral
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Summary Panel