Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15459

Make dependencies optional in sets-of-DataUnits lookups

    Details

      Description

      In the various places where we look up DataUnit information (joins, regions) for different sets of DataUnit [names], we are not consistent about whether dependencies should be included in those sets.  We should make sure all APIs support any amount of included dependencies (including optionals).

      While I'd originally wanted to do this on DM-15034, and I still expect that to provide the best solution, some functionality is currently broken, so we can't afford to wait to do something about it.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Nate Lust, I think this will solve at least some of the test failures on DM-15336 if you rebase on it, so you get the review.

            PR is here: https://github.com/lsst/daf_butler/pull/82

            Show
            jbosch Jim Bosch added a comment - Nate Lust , I think this will solve at least some of the test failures on DM-15336 if you rebase on it, so you get the review. PR is here: https://github.com/lsst/daf_butler/pull/82
            Hide
            nlust Nate Lust added a comment -

            I did not run a linter or jenkins or anything on this, but it looks good to me

            Show
            nlust Nate Lust added a comment - I did not run a linter or jenkins or anything on this, but it looks good to me
            Hide
            jbosch Jim Bosch added a comment -

            Thanks. daf_butler has branch protection linting via Travis, but thanks for the reminder on Jenkins. That's running now, but you can go ahead and rebase on the ticket branch; rebasing on master after it merges after that should be a no-op in terms of conflict resolution unless something really unexpected breaks.

            Show
            jbosch Jim Bosch added a comment - Thanks. daf_butler has branch protection linting via Travis, but thanks for the reminder on Jenkins. That's running now, but you can go ahead and rebase on the ticket branch; rebasing on master after it merges after that should be a no-op in terms of conflict resolution unless something really unexpected breaks.
            Hide
            jbosch Jim Bosch added a comment -

            Merged to master.

            Show
            jbosch Jim Bosch added a comment - Merged to master.

              People

              • Assignee:
                jbosch Jim Bosch
                Reporter:
                jbosch Jim Bosch
                Reviewers:
                Nate Lust
                Watchers:
                Andy Salnikov, Jim Bosch, Nate Lust
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel