Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15479

Only set ds9 as a default afwDisplay backend if no backend is defined

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Team:
      DM Science

      Description

      The code in afw.display.ds9 sets the default backend to ds9 even if a default is already set.  Please fix this.

       

      N.b. the setting of the default to ds9 is part of the backwards-compatibility effort.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          rhl Robert Lupton added a comment -

          This ticket makes your work with Lauren much less urgent!

          I'll create the pull request next

          Show
          rhl Robert Lupton added a comment - This ticket makes your work with Lauren much less urgent! I'll create the pull request next
          Hide
          Permalink
          lauren Lauren MacArthur added a comment -

          Regardless, I am working on DM-13432 now.  It's a bit slow-going as we have to clean up the bitrot in many places (mostly scripts in the examples/ dirs and lsstDebug code blocks) in order to check the changes, but I'm getting there.

          Show
          lauren Lauren MacArthur added a comment - Regardless, I am working on DM-13432 now.  It's a bit slow-going as we have to clean up the bitrot in many places (mostly scripts in the examples/ dirs and lsstDebug code blocks) in order to check the changes, but I'm getting there.
          Hide
          Permalink
          yusra Yusra AlSayyad added a comment -

          OK to merge.

          Commit message is OK, but I wanted to draw your attention to https://developer.lsst.io/work/flow.html#appendix-commit-message-best-practices

          Show
          yusra Yusra AlSayyad added a comment - OK to merge. Commit message is OK, but I wanted to draw your attention to https://developer.lsst.io/work/flow.html#appendix-commit-message-best-practices
          Hide
          Permalink
          yusra Yusra AlSayyad added a comment - - edited

          For posterity, the problem this fixes can be reproduced by

          >>> from lsst.afw.display import setDefaultBackend, getDefaultBackend, Display
          		 
          >>> setDefaultBackend("firefly")
          		 
          >>> getDefaultBackend()
          		 
          'firefly'
          		 
          >>> import lsst.meas.algorithms
          		 
          >>> getDefaultBackend()
          		 
          'lsst.display.ds9'

          Show
          yusra Yusra AlSayyad added a comment - - edited For posterity, the problem this fixes can be reproduced by >>> from lsst.afw.display import setDefaultBackend, getDefaultBackend, Display >>> setDefaultBackend("firefly") >>> getDefaultBackend() 'firefly' >>> import lsst.meas.algorithms >>> getDefaultBackend() 'lsst.display.ds9'
          Hide
          Permalink
          rhl Robert Lupton added a comment -

          Merged, Jenkinsed, and pushed

          Show
          rhl Robert Lupton added a comment - Merged, Jenkinsed, and pushed

            People

            Assignee:
            rhl Robert Lupton
            Reporter:
            rhl Robert Lupton
            Reviewers:
            Yusra AlSayyad
            Watchers:
            John Swinbank, Lauren MacArthur, Robert Lupton, Yusra AlSayyad
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.