Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15509

Fix bitrot due to premature merge of DM-13293 in obs_lsstCam

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_lsst
    • Labels:
      None

      Description

      TL;DR - Merlin messed up and merged early (there were reasons at the time), so this ticket is to apply the changes necessary here to deal with the changes to cp_pipe from review comments.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13293 Make BF kernel measurement code fully stack compliant

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            So I do note that this isn't done yet, and realise it's premature for a review. But... please do fix the commit message before you merge. Future-you (or future-me) does not want to have to look up DM-13293 and figure out what problems it introduced in order to understand what happened on this ticket.

            Show
            swinbank John Swinbank added a comment - So I do note that this isn't done yet, and realise it's premature for a review. But... please do fix the commit message before you merge. Future-you (or future-me) does not want to have to look up DM-13293 and figure out what problems it introduced in order to understand what happened on this ticket.
            Hide
            Permalink
            mfisherlevine Merlin Fisher-Levine added a comment -

            Good point - done.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Good point - done.
            Hide
            Permalink
            mfisherlevine Merlin Fisher-Levine added a comment -

            Apologies, please consider this the obs_lsstCam branch of DM-13293. I think this should be 100% straightforward though.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Apologies, please consider this the obs_lsstCam branch of DM-13293 . I think this should be 100% straightforward though.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Looks good to me.

            Show
            rowen Russell Owen added a comment - Looks good to me.
            Hide
            Permalink
            mfisherlevine Merlin Fisher-Levine added a comment -

            Merged.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Merged.

              People

              Assignee:
              mfisherlevine Merlin Fisher-Levine
              Reporter:
              mfisherlevine Merlin Fisher-Levine
              Reviewers:
              Russell Owen
              Watchers:
              John Swinbank, Merlin Fisher-Levine, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.