Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15509

Fix bitrot due to premature merge of DM-13293 in obs_lsstCam

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • obs_lsst
    • None

    Description

      TL;DR - Merlin messed up and merged early (there were reasons at the time), so this ticket is to apply the changes necessary here to deal with the changes to cp_pipe from review comments.

      Attachments

        Issue Links

          Activity

            No builds found.
            mfisherlevine Merlin Fisher-Levine created issue -
            mfisherlevine Merlin Fisher-Levine made changes -
            Field Original Value New Value
            Risk Score 0

            So I do note that this isn't done yet, and realise it's premature for a review. But... please do fix the commit message before you merge. Future-you (or future-me) does not want to have to look up DM-13293 and figure out what problems it introduced in order to understand what happened on this ticket.

            swinbank John Swinbank added a comment - So I do note that this isn't done yet, and realise it's premature for a review. But... please do fix the commit message before you merge. Future-you (or future-me) does not want to have to look up DM-13293 and figure out what problems it introduced in order to understand what happened on this ticket.
            swinbank John Swinbank made changes -
            Epic Link DM-14405 [ 79812 ]
            swinbank John Swinbank made changes -
            Team Data Release Production [ 10301 ]
            mfisherlevine Merlin Fisher-Levine made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]

            Good point - done.

            mfisherlevine Merlin Fisher-Levine added a comment - Good point - done.

            Apologies, please consider this the obs_lsstCam branch of DM-13293. I think this should be 100% straightforward though.

            mfisherlevine Merlin Fisher-Levine added a comment - Apologies, please consider this the obs_lsstCam branch of DM-13293 . I think this should be 100% straightforward though.
            mfisherlevine Merlin Fisher-Levine made changes -
            Reviewers Russell Owen [ rowen ]
            Status In Progress [ 3 ] In Review [ 10004 ]

            Looks good to me.

            rowen Russell Owen added a comment - Looks good to me.
            rowen Russell Owen made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]

            Merged.

            mfisherlevine Merlin Fisher-Levine added a comment - Merged.
            mfisherlevine Merlin Fisher-Levine made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            tjenness Tim Jenness made changes -
            Component/s obs_lsst [ 16504 ]
            Component/s obs_lsstCam [ 15215 ]
            tjenness Tim Jenness made changes -
            Link This issue is triggered by DM-13293 [ DM-13293 ]

            People

              mfisherlevine Merlin Fisher-Levine
              mfisherlevine Merlin Fisher-Levine
              Russell Owen
              John Swinbank, Merlin Fisher-Levine, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.