Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15511

Remove pex logging from base package

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: base
    • Labels:
      None
    • Team:
      Architecture

      Description

      Base still use pex loggin in file:

      python/lsst/base/packages.py

       

      in line 162.

      Default logging shall be used instead and  "warning" shall be used instead of warn in line 163.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          gcomoretto Gabriele Comoretto [X] (Inactive) created issue -
          gcomoretto Gabriele Comoretto [X] (Inactive) made changes -
          Field Original Value New Value
          Risk Score 0
          gcomoretto Gabriele Comoretto [X] (Inactive) made changes -
          Reviewers Paul Price [ price ]
          Status To Do [ 10001 ] In Review [ 10004 ]
          Hide
          Permalink
          tjenness Tim Jenness added a comment -

          The main question is whether this should be warnings.warn or log.warning. Kian-Tat Lim do you have an opinion?

          Show
          tjenness Tim Jenness added a comment - The main question is whether this should be warnings.warn or log.warning . Kian-Tat Lim do you have an opinion?
          Hide
          Permalink
          price Paul Price added a comment -

          I'm fine with this once Tim Jenness 's question has been resolved and the solution has been tested.

          Show
          price Paul Price added a comment - I'm fine with this once Tim Jenness 's question has been resolved and the solution has been tested.
          price Paul Price made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment -

          I think this should be a log.warning.  My feeling is that warnings.warn should be reserved for Python itself or very-commonly-used Python libraries.  Since it uses a totally different filtering mechanism from all other LSST messages, we should almost never use it.

          Show
          ktl Kian-Tat Lim added a comment - I think this should be a log.warning .  My feeling is that warnings.warn should be reserved for Python itself or very-commonly-used Python libraries.  Since it uses a totally different filtering mechanism from all other LSST messages, we should almost never use it.
          gcomoretto Gabriele Comoretto [X] (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]

            People

            Assignee:
            gcomoretto Gabriele Comoretto [X] (Inactive)
            Reporter:
            gcomoretto Gabriele Comoretto [X] (Inactive)
            Reviewers:
            Paul Price
            Watchers:
            Gabriele Comoretto [X] (Inactive), Kian-Tat Lim, Paul Price, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.