Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15515

Help turn on Travis for remaining repositories

    XMLWordPrintable

Details

    • Epic
    • Status: Done
    • Resolution: Done
    • None
    • Science Pipelines
    • None
    • travisify_F18
    • 20
    • External
    • Fall 2018

    Description

      Most repositories have had the configuration added to turn on flake8 checking on push. There are still a few that need this added. This epic is to help add that configuration and fix any linting issues that cause travis to fail.

      Attachments

        Issue Links

          Activity

            Here is the recipe provided by Russell:

            To enable Travis flake8:

            1: Visit the following page (which eventually will have complete instructions)
            https://developer.lsst.io/stack/adding-a-new-package.html?highlight=travis#configuring-github-repositories

            2: Save the following to the package root as a file named .travis.yaml
            sudo: false
            language: python
            matrix:
            include:

            • python: '3.6'
              install:
            • pip install flake8
              script: flake8

            3: Enable Travis for the repository by visiting:
            https://travis-ci.org/lsst/<repo_name> (e.g. https://travis-ci.org/lsst/afw)
            Click the "Activate" button
            We will change to travis-ci.com at some point, but LSST will say when;
            see https://docs.travis-ci.com/user/open-source-on-travis-ci-com/ for more info

            4: Make sure Travis runs
            If you have a ticket branch then push a change to it. If you are done working on that branch
            then use "git commit --amend" followed by "git push --force" to push a new SHA for your work.
            That should start Travis running. You can see this on github by viewing your branch
            (a pull request may be needed, but I don't think so).

            5: In github (after Travis runs for the first time) you can require it to pass before merging.
            Settings > Branches:
            x Require branches to be up to date before merging (this will already be checked)
            x Continuous Integration Travis/CI

            krughoff Simon Krughoff (Inactive) added a comment - Here is the recipe provided by Russell: To enable Travis flake8: 1: Visit the following page (which eventually will have complete instructions) https://developer.lsst.io/stack/adding-a-new-package.html?highlight=travis#configuring-github-repositories 2: Save the following to the package root as a file named .travis.yaml sudo: false language: python matrix: include: python: '3.6' install: pip install flake8 script: flake8 3: Enable Travis for the repository by visiting: https://travis-ci.org/lsst/ <repo_name> (e.g. https://travis-ci.org/lsst/afw ) Click the "Activate" button We will change to travis-ci.com at some point, but LSST will say when; see https://docs.travis-ci.com/user/open-source-on-travis-ci-com/ for more info 4: Make sure Travis runs If you have a ticket branch then push a change to it. If you are done working on that branch then use "git commit --amend" followed by "git push --force" to push a new SHA for your work. That should start Travis running. You can see this on github by viewing your branch (a pull request may be needed, but I don't think so). 5: In github (after Travis runs for the first time) you can require it to pass before merging. Settings > Branches: x Require branches to be up to date before merging (this will already be checked) x Continuous Integration Travis/CI
            tjenness Tim Jenness added a comment -

            Also look at tests/SConscript and add pyList=[] as an argument to the tests() method there. This enables automatic file detection in pytest when run from sconsUtils.

            tjenness Tim Jenness added a comment - Also look at tests/SConscript and add pyList=[] as an argument to the tests() method there. This enables automatic file detection in pytest when run from sconsUtils.
            tjenness Tim Jenness added a comment -

            Closing this as we have long since moved to GitHub actions and enabled the flake8 tests using that for all packages.

            tjenness Tim Jenness added a comment - Closing this as we have long since moved to GitHub actions and enabled the flake8 tests using that for all packages.

            People

              jcarlin Jeffrey Carlin
              krughoff Simon Krughoff (Inactive)
              Simon Krughoff (Inactive)
              Simon Krughoff (Inactive), Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.