Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15534

Undefined variable names in MultibandDriver

    XMLWordPrintable

    Details

    • Story Points:
      3
    • Sprint:
      DRP F18-3, DRP F18-4
    • Team:
      Data Release Production

      Description

      DM-15104 introduced some undefined variable names into MultibandDriver.py. Because there are no automated checks in in place for pipe_drivers (no unit tests or Travis) these were missed.

      --reuse deblendCoaddSources will not work:
      https://github.com/lsst/pipe_drivers/blob/master/python/lsst/pipe/drivers/multiBandDriver.py#L419

        Attachments

          Issue Links

            Activity

            Hide
            yusra Yusra AlSayyad added a comment -

            Worked on this ticket with Dan Taranu for pair coding.

            Note: the way the DeblendCoaddSourcesTask task instantiates the two different deblender options as subtasks with different names is unfortunate:

            https://github.com/lsst/pipe_tasks/blob/master/python/lsst/pipe/tasks/multiBand.py#L950

            but fixing this was out of scope for this ticket.

            Show
            yusra Yusra AlSayyad added a comment - Worked on this ticket with Dan Taranu for pair coding. Note: the way the DeblendCoaddSourcesTask task instantiates the two different deblender options as subtasks with different names is unfortunate: https://github.com/lsst/pipe_tasks/blob/master/python/lsst/pipe/tasks/multiBand.py#L950 but fixing this was out of scope for this ticket.

              People

              Assignee:
              yusra Yusra AlSayyad
              Reporter:
              yusra Yusra AlSayyad
              Reviewers:
              Jim Bosch
              Watchers:
              Hsin-Fang Chiang, Jim Bosch, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.