Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15534

Undefined variable names in MultibandDriver

    XMLWordPrintable

    Details

    • Story Points:
      3
    • Epic Link:
    • Sprint:
      DRP F18-3, DRP F18-4
    • Team:
      Data Release Production

      Description

      DM-15104 introduced some undefined variable names into MultibandDriver.py. Because there are no automated checks in in place for pipe_drivers (no unit tests or Travis) these were missed.

      --reuse deblendCoaddSources will not work:
      https://github.com/lsst/pipe_drivers/blob/master/python/lsst/pipe/drivers/multiBandDriver.py#L419

        Attachments

          Issue Links

          is child task of

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15104 Move SourceDeblendTask out of MeasureCoaddSources

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15531 Fix deblender defaults in in new DeblendCoaddSourcesTask

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            yusra Yusra AlSayyad created issue -
            yusra Yusra AlSayyad made changes -
            Field Original Value New Value
            Epic Link DM-14405 [ 79812 ]
            yusra Yusra AlSayyad made changes -
            Link This issue is child task of DM-15104 [ DM-15104 ]
            yusra Yusra AlSayyad made changes -
            Risk Score 0
            yusra Yusra AlSayyad made changes -
            Description DM-15104 introduced some undefined variable names into MultibandDriver.py. Because there are no automated checks in in place for pipe_drivers (no unit tests or Travis) these were missed. DM-15104 introduced some undefined variable names into MultibandDriver.py. Because there are no automated checks in in place for pipe_drivers (no unit tests or Travis) these were missed.

            {{--reuse deblendCoaddSources}} will not work:
            https://github.com/lsst/pipe_drivers/blob/master/python/lsst/pipe/drivers/multiBandDriver.py#L419
            yusra Yusra AlSayyad made changes -
            Link This issue is child task of DM-15531 [ DM-15531 ]
            yusra Yusra AlSayyad made changes -
            Sprint DRP F18-3 [ 768 ] DRP F18-3, DRP F18-4 [ 768, 774 ]
            yusra Yusra AlSayyad made changes -
            Labels PairCoding
            yusra Yusra AlSayyad made changes -
            Story Points 0.5 1.5
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment -

            Worked on this ticket with Dan Taranu for pair coding.

            Note: the way the DeblendCoaddSourcesTask task instantiates the two different deblender options as subtasks with different names is unfortunate:

            https://github.com/lsst/pipe_tasks/blob/master/python/lsst/pipe/tasks/multiBand.py#L950

            but fixing this was out of scope for this ticket.

            Show
            yusra Yusra AlSayyad added a comment - Worked on this ticket with Dan Taranu for pair coding. Note: the way the DeblendCoaddSourcesTask task instantiates the two different deblender options as subtasks with different names is unfortunate: https://github.com/lsst/pipe_tasks/blob/master/python/lsst/pipe/tasks/multiBand.py#L950 but fixing this was out of scope for this ticket.
            yusra Yusra AlSayyad made changes -
            Reviewers Jim Bosch [ jbosch ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            jbosch Jim Bosch made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            yusra Yusra AlSayyad made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            yusra Yusra AlSayyad made changes -
            Story Points 1.5 3

              People

              Assignee:
              yusra Yusra AlSayyad
              Reporter:
              yusra Yusra AlSayyad
              Reviewers:
              Jim Bosch
              Watchers:
              Hsin-Fang Chiang, Jim Bosch, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.