Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15552

Convert meas_deblender to numpydoc status

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Sprint:
      AP F18-4, AP F18-5, AP F18-6, AP F21-3 (August), AP F21-4 (September)
    • Team:
      Alert Production
    • Urgent?:
      No

      Attachments

        Issue Links

          Activity

          Hide
          swinbank John Swinbank added a comment -

          Hey Andres — I don't think you're actively working on this, so I'm unassigning you. If you'd like it back, please do shout!

          Show
          swinbank John Swinbank added a comment - Hey Andres — I don't think you're actively working on this, so I'm unassigning you. If you'd like it back, please do shout!
          Hide
          plazas Andrés Alejandro Plazas Malagón added a comment -

          Sounds good. Thank you!

          Show
          plazas Andrés Alejandro Plazas Malagón added a comment - Sounds good. Thank you!
          Hide
          samquist Sam Quist added a comment -

          Errors: OrderedDict error from Sphinx - _all_ in baseline.py statement line too long, r""" solution works for Travis but is not appreciated by sphinx - returns Inline literal start-string without end-string error. This occurs 2 times in plugins.py and once in baseline.py

           

          Show
          samquist Sam Quist added a comment - Errors: OrderedDict error from Sphinx - _ all _ in baseline.py statement line too long, r""" solution works for Travis but is not appreciated by sphinx - returns Inline literal start-string without end-string error. This occurs 2 times in plugins.py and once in baseline.py  
          Hide
          swinbank John Swinbank added a comment -
          • There are a lot of non-public names (starting with _) being exported from plugins.py. Best to drop in an __all__ to suppress them.
          • Please check that all the docstrings comply with the line-length rules
          • Do we need the docstring in __init__.py?
          • Note that some functions aren't documented as things are currently configured. (For example: where is the documentation for this function?). I will push a fix onto your branch; please take a look, see if you understand it, and we can discuss when we next meet.
          Show
          swinbank John Swinbank added a comment - There are a lot of non-public names (starting with _ ) being exported from plugins.py . Best to drop in an __all__ to suppress them. Please check that all the docstrings comply with the line-length rules Do we need the docstring in __init__.py ? Note that some functions aren't documented as things are currently configured. (For example: where is the documentation for this function ?). I will push a fix onto your branch; please take a look, see if you understand it, and we can discuss when we next meet.
          Hide
          swinbank John Swinbank added a comment -

          Also, please remove the obsolete

          ## \addtogroup LSST_task_documentation
          ## \{
          ## \page SourceDeblendTask
          ## \ref SourceDeblendTask_ "SourceDeblendTask"
          ## \copybrief SourceDeblendTask
          ## \}
          

          block

          Show
          swinbank John Swinbank added a comment - Also, please remove the obsolete ## \addtogroup LSST_task_documentation ## \{ ## \page SourceDeblendTask ## \ref SourceDeblendTask_ "SourceDeblendTask" ## \copybrief SourceDeblendTask ## \} block
          Show
          Parejkoj John Parejko added a comment - Post-cleanup Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35003/pipeline
          Hide
          Parejkoj John Parejko added a comment -

          John Swinbank reviewed it initially, and I've looked it over and gotten the docs to build cleanly.

          Show
          Parejkoj John Parejko added a comment - John Swinbank reviewed it initially, and I've looked it over and gotten the docs to build cleanly.

            People

            Assignee:
            Parejkoj John Parejko
            Reporter:
            dstaker David Staker [X] (Inactive)
            Reviewers:
            John Swinbank
            Watchers:
            Andrés Alejandro Plazas Malagón, John Parejko, John Swinbank, Sam Quist
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins Builds

                No builds found.