Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15552

Convert meas_deblender to numpydoc status

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Sprint:
      AP F18-4, AP F18-5, AP F18-6, AP F21-3 (August), AP F21-4 (September)
    • Team:
      Alert Production
    • Urgent?:
      No

      Attachments

        Issue Links

          Activity

          No builds found.
          dstaker David Staker [X] (Inactive) created issue -
          dstaker David Staker [X] (Inactive) made changes -
          Field Original Value New Value
          Risk Score 0
          dstaker David Staker [X] (Inactive) made changes -
          Summary Convert meas_deblend to numpydoc status Convert meas_deblender to numpydoc status
          swinbank John Swinbank made changes -
          Epic Link DM-14447 [ 80385 ]
          swinbank John Swinbank made changes -
          Sprint AP F18-4 [ 749 ]
          Team Alert Production [ 10300 ]
          dstaker David Staker [X] (Inactive) made changes -
          Assignee David Staker [ dstaker ]
          swinbank John Swinbank made changes -
          Remote Link This issue links to "Page (Confluence)" [ 17970 ]
          swinbank John Swinbank made changes -
          Component/s meas_deblender [ 10741 ]
          swinbank John Swinbank made changes -
          Labels numpydoc
          swinbank John Swinbank made changes -
          Sprint AP F18-4 [ 749 ] AP F18-4, AP F18-5 [ 749, 750 ]
          swinbank John Swinbank made changes -
          Sprint AP F18-4, AP F18-5 [ 749, 750 ] AP F18-4, AP F18-5, AP F18-6 [ 749, 750, 751 ]
          swinbank John Swinbank made changes -
          Assignee David Staker [ dstaker ] John Swinbank [ swinbank ]
          swinbank John Swinbank made changes -
          Epic Link DM-14447 [ 80385 ] DM-16722 [ 235355 ]
          swinbank John Swinbank made changes -
          Sprint AP F18-4, AP F18-5, AP F18-6 [ 749, 750, 751 ] AP F18-4, AP F18-5, AP F18-6, AP S19-1 [ 749, 750, 751, 825 ]
          swinbank John Swinbank made changes -
          Assignee John Swinbank [ swinbank ]
          swinbank John Swinbank made changes -
          Sprint AP F18-4, AP F18-5, AP F18-6, AP S19-1 [ 749, 750, 751, 825 ] AP F18-4, AP F18-5, AP F18-6 [ 749, 750, 751 ]
          plazas Andrés Alejandro Plazas Malagón made changes -
          Assignee Andrés Alejandro Plazas Malagón [ plazas ]
          plazas Andrés Alejandro Plazas Malagón made changes -
          Link This issue is parent task of DM-16901 [ DM-16901 ]
          swinbank John Swinbank made changes -
          Epic Link DM-16722 [ 235355 ] DM-17887 [ 240317 ]
          swinbank John Swinbank made changes -
          Epic Link DM-17887 [ 240317 ] DM-19979 [ 307530 ]
          swinbank John Swinbank made changes -
          Epic Link DM-19979 [ 307530 ] DM-21441 [ 423048 ]
          swinbank John Swinbank made changes -
          Epic Link DM-21441 [ 423048 ] DM-22484 [ 427311 ]
          swinbank John Swinbank made changes -
          Epic Link DM-22484 [ 427311 ] DM-24339 [ 433026 ]
          Hide
          swinbank John Swinbank added a comment -

          Hey Andres — I don't think you're actively working on this, so I'm unassigning you. If you'd like it back, please do shout!

          Show
          swinbank John Swinbank added a comment - Hey Andres — I don't think you're actively working on this, so I'm unassigning you. If you'd like it back, please do shout!
          Hide
          plazas Andrés Alejandro Plazas Malagón added a comment -

          Sounds good. Thank you!

          Show
          plazas Andrés Alejandro Plazas Malagón added a comment - Sounds good. Thank you!
          swinbank John Swinbank made changes -
          Assignee Andrés Alejandro Plazas Malagón [ plazas ]
          swinbank John Swinbank made changes -
          Epic Link DM-24339 [ 433026 ] DM-25142 [ 435260 ]
          swinbank John Swinbank made changes -
          Assignee Sam Quist [ samquist ]
          swinbank John Swinbank made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          Hide
          samquist Sam Quist added a comment -

          Errors: OrderedDict error from Sphinx - _all_ in baseline.py statement line too long, r""" solution works for Travis but is not appreciated by sphinx - returns Inline literal start-string without end-string error. This occurs 2 times in plugins.py and once in baseline.py

           

          Show
          samquist Sam Quist added a comment - Errors: OrderedDict error from Sphinx - _ all _ in baseline.py statement line too long, r""" solution works for Travis but is not appreciated by sphinx - returns Inline literal start-string without end-string error. This occurs 2 times in plugins.py and once in baseline.py  
          samquist Sam Quist made changes -
          Reviewers John Swinbank [ swinbank ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          Hide
          swinbank John Swinbank added a comment -
          • There are a lot of non-public names (starting with _) being exported from plugins.py. Best to drop in an __all__ to suppress them.
          • Please check that all the docstrings comply with the line-length rules
          • Do we need the docstring in __init__.py?
          • Note that some functions aren't documented as things are currently configured. (For example: where is the documentation for this function?). I will push a fix onto your branch; please take a look, see if you understand it, and we can discuss when we next meet.
          Show
          swinbank John Swinbank added a comment - There are a lot of non-public names (starting with _ ) being exported from plugins.py . Best to drop in an __all__ to suppress them. Please check that all the docstrings comply with the line-length rules Do we need the docstring in __init__.py ? Note that some functions aren't documented as things are currently configured. (For example: where is the documentation for this function ?). I will push a fix onto your branch; please take a look, see if you understand it, and we can discuss when we next meet.
          Hide
          swinbank John Swinbank added a comment -

          Also, please remove the obsolete

          ## \addtogroup LSST_task_documentation
          ## \{
          ## \page SourceDeblendTask
          ## \ref SourceDeblendTask_ "SourceDeblendTask"
          ## \copybrief SourceDeblendTask
          ## \}
          

          block

          Show
          swinbank John Swinbank added a comment - Also, please remove the obsolete ## \addtogroup LSST_task_documentation ## \{ ## \page SourceDeblendTask ## \ref SourceDeblendTask_ "SourceDeblendTask" ## \copybrief SourceDeblendTask ## \} block
          swinbank John Swinbank made changes -
          Link This issue relates to RFC-717 [ RFC-717 ]
          swinbank John Swinbank made changes -
          Urgent? off
          Watchers Andrés Alejandro Plazas Malagón, David Staker [X], John Swinbank, Sam Quist [ Andrés Alejandro Plazas Malagón, David Staker [X], John Swinbank, Sam Quist ] Andrés Alejandro Plazas Malagón, John Swinbank, Sam Quist [ Andrés Alejandro Plazas Malagón, John Swinbank, Sam Quist ]
          swinbank John Swinbank made changes -
          Story Points 4
          Parejkoj John Parejko made changes -
          Assignee Sam Quist [ samquist ] John Parejko [ parejkoj ]
          sullivan Ian Sullivan made changes -
          Sprint AP F18-4, AP F18-5, AP F18-6 [ 749, 750, 751 ] AP F18-4, AP F18-5, AP F18-6, AP F21-3 (August) [ 749, 750, 751, 1109 ]
          sullivan Ian Sullivan made changes -
          Epic Link DM-25142 [ 435260 ] DM-30431 [ 504819 ]
          sullivan Ian Sullivan made changes -
          Rank Ranked higher
          sullivan Ian Sullivan made changes -
          Sprint AP F18-4, AP F18-5, AP F18-6, AP F21-3 (August) [ 749, 750, 751, 1109 ] AP F18-4, AP F18-5, AP F18-6, AP F21-3 (August), AP F21-4 (September) [ 749, 750, 751, 1109, 1113 ]
          sullivan Ian Sullivan made changes -
          Epic Link DM-30431 [ 504819 ] DM-30514 [ 510188 ]
          Show
          Parejkoj John Parejko added a comment - Post-cleanup Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35003/pipeline
          Hide
          Parejkoj John Parejko added a comment -

          John Swinbank reviewed it initially, and I've looked it over and gotten the docs to build cleanly.

          Show
          Parejkoj John Parejko added a comment - John Swinbank reviewed it initially, and I've looked it over and gotten the docs to build cleanly.
          Parejkoj John Parejko made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Parejkoj John Parejko made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          sullivan Ian Sullivan made changes -
          Rank Ranked higher

            People

            Assignee:
            Parejkoj John Parejko
            Reporter:
            dstaker David Staker [X] (Inactive)
            Reviewers:
            John Swinbank
            Watchers:
            Andrés Alejandro Plazas Malagón, John Parejko, John Swinbank, Sam Quist
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.