Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: pipe_analysis
-
Labels:None
-
Story Points:4
-
Epic Link:
-
Sprint:DRP F18-3, DRP F18-4, DRP F18-5
-
Team:Data Release Production
Description
Various updates are needed in the comparison scripts. Namely, some plotting limits and missing comparison plots as well as fixing the task runner such that the output rerun directory can be specified by the --rerun inDir:outDir method which is currently broken due to the implementation of the --rerun2 in2Dir (i.e. the comparison directory).
Attachments
Activity
To facilitate a combined test, the current branch has been rebased against DM-15689 and I have setup the tickets/DM-15916 branch of meas_mosaic. I have tried running every combination of pipeAnalysisTask.py vs. old rerun (RC/w_2018_32/DM-15184/, which is pre both calib_psfUsed->calib_psf_used & flux->instFlux) and vs. latest rerun (RC/w_2018_41/DM-16011), including old vs. new along with output redirection in the comparison scripts and all processed all the way through. The results can be viewed at w32: https://lsst-web.ncsa.illinois.edu/~lauren/lauren/instFluxBack/ and w41: https://lsst-web.ncsa.illinois.edu/~lauren/lauren/instFlux/
Hsin-Fang Chiang this is now ready for review...is it too much to ask that you do a combined DM-15916, DM-15869, DM-15569 review? As stated above, the tickets/DM-15916 branch of meas_mosaic needs to be setup for this to work and I have rebased this branch on top of tickets/DM-155869 of pipe_analysis so it all works with current master.
LGTM. I ran a simple example and also used the branch to do w_2018_38, and all seemed to work fine so far. I would think the rerun input/output feature be handled in the pipe_base base class, but your approach in pipe_analysis is probably fine too, given that both pipe_analysis and CmdLineTask are to be replaced soon.
Hsin-Fang Chiang
added a comment - LGTM. I ran a simple example and also used the branch to do w_2018_38, and all seemed to work fine so far. I would think the rerun input/output feature be handled in the pipe_base base class, but your approach in pipe_analysis is probably fine too, given that both pipe_analysis and CmdLineTask are to be replaced soon. Thanks! Yeah, I don't think there's any impetus for rerun functionality changes in the main stack.
We discussed the CModel vs PSF flux issue at the Monday morning meeting here in Princeton (including our Princeton-non local contingent via BlueJeans). Consensus was reached that it makes sense to use the CModel fluxes for these diagnostic plots. The understanding for anyone using the plots is that they should not be used to asses detections limits/thresholds (the selection function with CModel will be more of a slope than a simple vertical line). Since we are not using these plots for such purposes, plotting the best measured flux (CModel for coadds) is desirable.
If there is a specific interest in assessing detection limits and thresholding via the pipe_analysis scripts, a dedicated (set of) plot(s) should be created.