Status: Won't Fix
Fix Version/s: None
Team:Data Release Production
I have several requested improvements to the BF kernel code, one of which I have implemented:
(1) When run with level='AMP', the code quits if there is a bad amplifier, where we really want it to continue and do the other amps. I added fixes to makeBrighterFatterKernel.py in two places that fix this up.
(2) The code outputs:
makeBrighterFatterKernel INFO: Skipped enforcing doOverscan as key was not present in config dict
I tried adding doOverscan = True to config.isr in obs_lsstCam/config/makeBrighterFatterKernel.py, but then I got the error:
AttributeError: lsst.ip.isr.isrTask.IsrTaskConfig has no attribute doOverscan
so I am confused. Is it doing overscan subtraction or not?
(3) I would like the code to keep the correlations and means data, so I can compare to my code here. I tried adding this to the code with dataRef.put, but failed, since there is some dependency that I don't understand. For now, I'll just have the code pickle these to a file for my comparisons.
The notebook I have been using, and the modifications to makeBrighterFatterKernel.py are at the link below. Search on "Lage hack" to find the changes.