Details
-
Type:
Improvement
-
Status: Won't Fix
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: cp_pipe
-
Labels:None
-
Story Points:0
-
Team:Data Release Production
Description
I have several requested improvements to the BF kernel code, one of which I have implemented:
(1) When run with level='AMP', the code quits if there is a bad amplifier, where we really want it to continue and do the other amps. I added fixes to makeBrighterFatterKernel.py in two places that fix this up.
(2) The code outputs:
makeBrighterFatterKernel INFO: Skipped enforcing doOverscan as key was not present in config dict
I tried adding doOverscan = True to config.isr in obs_lsstCam/config/makeBrighterFatterKernel.py, but then I got the error:
AttributeError: lsst.ip.isr.isrTask.IsrTaskConfig has no attribute doOverscan
so I am confused. Is it doing overscan subtraction or not?
(3) I would like the code to keep the correlations and means data, so I can compare to my code here. I tried adding this to the code with dataRef.put, but failed, since there is some dependency that I don't understand. For now, I'll just have the code pickle these to a file for my comparisons.
The notebook I have been using, and the modifications to makeBrighterFatterKernel.py are at the link below. Search on "Lage hack" to find the changes.
https://github.com/craiglagegit/BF_Kernel/tree/master/cp_pipe_mods
Attachments
Issue Links
Activity
How much of this is still relevant? Especially now things are in gen3?
Most or all of these things are already implemented in the current code. OK with me to mark it done.
You filed the ticket so if you think it's no longer needed please close it.
1) This is something that should 100% be implemented. If we think that 100% of the 3024 amplifiers in the LSST camera will all work all the time we're delusional.
2) Just ignore that, that's testing something that's only in obs_subaru I think. It should probably be removed, but camera agnosticism is a tricky thing sometimes.
3) I think for now, hacking the code around and pickling it yourself is the way forward.