Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15606

Add jointcal config defaults to at least obs_subaru

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
      None
    • Story Points:
      3
    • Epic Link:
    • Sprint:
      DRP F18-4
    • Team:
      Data Release Production

      Description

      Add reference catalog defaults to at least obs_subaru to facilitate running jointcal on the HSC biweeklies.

      John Parejko I assigned it to you, but I can just as easily do it if one of you sends me the command to run jointcal on the RC2 dataset so I can test that the configs make it do what we expect.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          11 older comments
          Hide
          Permalink
          yusra Yusra AlSayyad added a comment -

          A configfile solution is on u/yusra/DM-15606 in jointcal and passes Jenkins (https://ci.lsst.codes/job/stack-os-matrix/28702).  I'll open a PR if you'd be up for reviewing. Before merging, I would put it on tickets/DM-15606 and squash the commits. 

          I added the config.astrometryVisitOrder = 7 to the obs_subaru PR too.

          Show
          yusra Yusra AlSayyad added a comment - A configfile solution is on u/yusra/ DM-15606 in jointcal and passes Jenkins ( https://ci.lsst.codes/job/stack-os-matrix/28702 ).  I'll open a PR if you'd be up for reviewing. Before merging, I would put it on tickets/ DM-15606  and squash the commits.  I added the config.astrometryVisitOrder = 7 to the obs_subaru PR too.
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          Quick skim suggests this is much better than my attempt. I'd be happy to review, and will expedite it: rename the ticket branch now (feel free to wipe out my branch above) and do whatever squashing you want, and I'll review the PR asap.

          Show
          Parejkoj John Parejko added a comment - Quick skim suggests this is much better than my attempt. I'd be happy to review, and will expedite it: rename the ticket branch now (feel free to wipe out my branch above) and do whatever squashing you want, and I'll review the PR asap.
          Hide
          Permalink
          yusra Yusra AlSayyad added a comment -

          Commits squashed, PR opened, and https://ci.lsst.codes/job/stack-os-matrix/28714 succeeded.

          Show
          yusra Yusra AlSayyad added a comment - Commits squashed, PR opened, and https://ci.lsst.codes/job/stack-os-matrix/28714  succeeded.
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          One tiny comment, otherwise this looks very good. Thanks for coming up with it!

          Show
          Parejkoj John Parejko added a comment - One tiny comment, otherwise this looks very good. Thanks for coming up with it!
          Hide
          Permalink
          yusra Yusra AlSayyad added a comment -

          Thank you John Parejko

          Show
          yusra Yusra AlSayyad added a comment - Thank you John Parejko

            People

            Assignee:
            yusra Yusra AlSayyad
            Reporter:
            yusra Yusra AlSayyad
            Reviewers:
            John Parejko
            Watchers:
            Hsin-Fang Chiang, John Parejko, Paul Price, Yusra AlSayyad
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.