Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15638

Fix DcrCoadd subfilter order

    XMLWordPrintable

    Details

      Description

      The measured spectrum of simulated sources that are recovered after modeling with DcrCoadds appears to be inverted from the input simulations. There appears to be a bug in either the sign of the direction of DCR in the simulations or the modeling code, or there is a bug later when assigning wavelength ranges to DCR subfilters.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14739 Reproduce the results of DMTN-037 using simulated data based on the stackified DCR code

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-16119 Investigate additional pixels masked with "NO_DATA" after DCR shift

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-16130 Move image rotation calculation to VisitInfo.cc

          • To Do
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            sullivan Ian Sullivan added a comment -

            Resolution: The order of the DrModel subfilters was reversed, which was due to the calculated shift due to DCR having the wrong sign. There were several bugs that worked together in this: the rotation calculation was written for a flipped WCS, but if a non-flipped WCS was supplied it would be off by -90 degrees. Then, afwGeom.Extent2D() takes arguments in the order X,Y but had been supplied in the order Y,X, so that had been off by another 90 degrees. Finally, DCR is mostly symmetric around the center of the band, so everything still mostly worked even though the shift in each band had the wrong sign.

            Show
            sullivan Ian Sullivan added a comment - Resolution: The order of the DrModel subfilters was reversed, which was due to the calculated shift due to DCR having the wrong sign. There were several bugs that worked together in this: the rotation calculation was written for a flipped WCS, but if a non-flipped WCS was supplied it would be off by -90 degrees. Then, afwGeom.Extent2D() takes arguments in the order X,Y but had been supplied in the order Y,X, so that had been off by another 90 degrees. Finally, DCR is mostly symmetric around the center of the band, so everything still mostly worked even though the shift in each band had the wrong sign.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for updating the tests: I left one more comment, but once you've dealt with that this is good to merge.

            Show
            Parejkoj John Parejko added a comment - Thanks for updating the tests: I left one more comment, but once you've dealt with that this is good to merge.

              People

              Assignee:
              sullivan Ian Sullivan
              Reporter:
              sullivan Ian Sullivan
              Reviewers:
              John Parejko
              Watchers:
              Ian Sullivan, John Parejko, John Swinbank
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.