Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15649

Add a test to check the logic of the calib_psf_* flag setting

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ci_hsc, pipe_tasks
    • Labels:
      None
    • Story Points:
      6
    • Epic Link:
    • Sprint:
      DRP F18-4
    • Team:
      Data Release Production

      Description

      DM-9358 fixes the flag setting logic for PSF determination.  The flawed logic was not being caught, so a test should be added to check this in CI.  The most likely place for this may be in ci_hsc (where the presence of these flags is being checked, but not the logic of what actually gets set).

        Attachments

          Issue Links

            Activity

            Hide
            lauren Lauren MacArthur added a comment -

            With this additional test, the current weekly + ci_hsc:tickets/DM-15649 fails with:

            AssertionError: Failed test: Number of candidate PSF stars >= sum of used and reserved stars (greater if any of the non-reserved candidates were rejected by the determiner) (112 >= 129)

            With the current weekly + ci_hsc:tickets/DM-15649 + pipe_tasks:tickets/DM-9358, ci_hsc builds/run successfully with messages like:

            root INFO: Number of candidate PSF stars >= sum of used and reserved stars (greater if any of the non-reserved candidates were rejected by the determiner) (141 >= 129): PASS

            A Jenkins with tickets/DM-15649 tickets/DM-9358 and lsst_distrib + ci_hsc is running.

            Show
            lauren Lauren MacArthur added a comment - With this additional test, the current weekly + ci_hsc :tickets/ DM-15649 fails with: AssertionError: Failed test: Number of candidate PSF stars >= sum of used and reserved stars (greater if any of the non-reserved candidates were rejected by the determiner) (112 >= 129) With the current weekly + ci_hsc :tickets/ DM-15649 + pipe_tasks :tickets/ DM-9358 , ci_hsc builds/run successfully with messages like: root INFO: Number of candidate PSF stars >= sum of used and reserved stars (greater if any of the non-reserved candidates were rejected by the determiner) (141 >= 129): PASS A Jenkins with tickets/ DM-15649 tickets/ DM-9358 and lsst_distrib + ci_hsc is running .
            Hide
            lauren Lauren MacArthur added a comment -

            Since you pointed out the need for this test, would you mind giving this a look?  Merging it is blocked on DM-9358 (pinging Robert Lupton ) for a review , but the Jenkins run with both ticket branches passed.

            In case it doesn't show up, PR is here

            Show
            lauren Lauren MacArthur added a comment - Since you pointed out the need for this test, would you mind giving this a look?  Merging it is blocked on DM-9358 (pinging Robert Lupton   ) for a review , but the Jenkins run with both ticket branches passed. In case it doesn't show up, PR is here
            Hide
            ktl Kian-Tat Lim added a comment -

            Looks fine to me.

            Show
            ktl Kian-Tat Lim added a comment - Looks fine to me.
            Hide
            lauren Lauren MacArthur added a comment -

            Thanks K.-T.  I finally got a review of DM-9358.  Rebased, reran Jenkins (passed), merged to master.

            Show
            lauren Lauren MacArthur added a comment - Thanks K.-T.  I finally got a review of DM-9358 .  Rebased, reran Jenkins (passed), merged to master.

              People

              • Assignee:
                lauren Lauren MacArthur
                Reporter:
                lauren Lauren MacArthur
                Reviewers:
                Kian-Tat Lim
                Watchers:
                Bob Armstrong, Kian-Tat Lim, Lauren MacArthur, Robert Lupton
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel