[DM-15683] Add tests for ip_isr/isrTask - Jira

XML

Word

Printable

Details

Type: Improvement
Status: Done
Resolution: Done
Fix Version/s: None
Component/s: ip_isr
Labels:
None

Story Points:
12
Epic Link:
s19-drp-emergent
Sprint:
DRP F18-4, DRP F18-5, DRP F18-6, DRP S19-1, DRP S19-2, DRP S19-3, DRP S19-4, DRP S19-5, DRP S19-6a
Team:
Data Release Production

Description

The current isrTask is poorly covered by the current tests, and there are a number of other ISR functions with no tests. Fix this.

Attachments

Issue Links

duplicates

DM-1683 Some tests compare local bboxes; why not parent?

Won't Fix

FF-depends on

DM-1448 Move code for mock images into afw so it reusable.

Done

is duplicated by

DM-6161 Add unit test for IsrTask

Invalid

DM-9374 Add missing unit tests to ip_isr

Invalid

is FF-depended by

DM-19707 ip_isr tests do not all test functionality

To Do

DM-4441 Support multi-mode fringe subtraction

Done

DM-18528 ip_isr MeasureCrosstalkTask cannot identify negative crosstalk signals

Invalid

verifies

DM-18065 Bad logic in saturation interpolation config options

Done

(2 is FF-depended by, 1 verifies)

Activity

Ascending order - Click to sort in descending order

No builds found.

Christopher Waters created issue - 07/Sep/18 3:58 PM

Christopher Waters made changes - 07/Sep/18 3:58 PM

Field	Original Value	New Value
Risk Score		0

Christopher Waters made changes - 07/Sep/18 4:06 PM

Link

This issue is duplicated by ~~DM-6161~~ [ ~~DM-6161~~ ]

Hide

Permalink

Christopher Waters added a comment - 07/Sep/18 4:06 PM

This ticket will resolve these.

Show

Christopher Waters added a comment - 07/Sep/18 4:06 PM This ticket will resolve these.

Christopher Waters made changes - 07/Sep/18 4:06 PM

Link

This issue is duplicated by ~~DM-9374~~ [ ~~DM-9374~~ ]

Christopher Waters made changes - 07/Sep/18 4:06 PM

Priority

Undefined [ 10000 ]

Major [ 3 ]

Hide

Permalink

Christopher Waters added a comment - 13/Sep/18 3:16 PM

I'm beginning work on this issue, using the ~~DM-6640~~ `ip_isr` as a basis, under the assumption that that will be merged first.

Show

Christopher Waters added a comment - 13/Sep/18 3:16 PM I'm beginning work on this issue, using the DM-6640 `ip_isr` as a basis, under the assumption that that will be merged first.

Christopher Waters made changes - 13/Sep/18 3:16 PM

Status

To Do [ 10001 ]

In Progress [ 3 ]

Yusra AlSayyad made changes - 14/Sep/18 1:09 PM

Sprint

DRP F18-4 [ 774 ]

Yusra AlSayyad made changes - 02/Oct/18 1:46 PM

Sprint

DRP F18-4 [ 774 ]

DRP F18-4, DRP F18-5 [ 774, 790 ]

Yusra AlSayyad made changes - 02/Oct/18 1:49 PM

Story Points

Yusra AlSayyad made changes - 02/Nov/18 4:50 PM

Sprint

DRP F18-4, DRP F18-5 [ 774, 790 ]

DRP F18-4, DRP F18-5, DRP F18-6 [ 774, 790, 811 ]

Yusra AlSayyad made changes - 02/Dec/18 1:36 PM

Sprint

DRP F18-4, DRP F18-5, DRP F18-6 [ 774, 790, 811 ]

DRP F18-4, DRP F18-5, DRP F18-6, DRP S19-1 [ 774, 790, 811, 822 ]

Yusra AlSayyad made changes - 10/Jan/19 2:23 PM

Sprint

DRP F18-4, DRP F18-5, DRP F18-6, DRP S19-1 [ 774, 790, 811, 822 ]

DRP F18-4, DRP F18-5, DRP F18-6, DRP S19-1, DRP S19-2 [ 774, 790, 811, 822, 840 ]

Yusra AlSayyad made changes - 05/Feb/19 2:18 PM

Link

This issue duplicates ~~DM-1683~~ [ ~~DM-1683~~ ]

Yusra AlSayyad made changes - 08/Feb/19 6:34 PM

Sprint

DRP F18-4, DRP F18-5, DRP F18-6, DRP S19-1, DRP S19-2 [ 774, 790, 811, 822, 840 ]

DRP F18-4, DRP F18-5, DRP F18-6, DRP S19-1, DRP S19-2, DRP S19-3 [ 774, 790, 811, 822, 840, 859 ]

Frossie Economou made changes - 10/Feb/19 7:12 PM

Status

Admin Review [ 3 ]

In Progress [ 11605 ]

Frossie Economou made changes - 11/Feb/19 9:46 AM

Status

Review [ 11605 ]

In Progress [ 3 ]

Christopher Waters made changes - 13/Feb/19 12:41 PM

Link

This issue FF-depends on ~~DM-1448~~ [ ~~DM-1448~~ ]

John Swinbank made changes - 24/Feb/19 1:19 PM

Epic Link

~~DM-16678~~ [ 235238 ]

Christopher Waters made changes - 26/Feb/19 10:01 AM

Link

This issue verifies ~~DM-18065~~ [ ~~DM-18065~~ ]

Christopher Waters made changes - 28/Feb/19 3:44 PM

Link

This issue is FF-depended by ~~DM-4441~~ [ ~~DM-4441~~ ]

Yusra AlSayyad made changes - 05/Mar/19 2:47 PM

Sprint

DRP F18-4, DRP F18-5, DRP F18-6, DRP S19-1, DRP S19-2, DRP S19-3 [ 774, 790, 811, 822, 840, 859 ]

DRP F18-4, DRP F18-5, DRP F18-6, DRP S19-1, DRP S19-2, DRP S19-3, DRP S19-4 [ 774, 790, 811, 822, 840, 859, 868 ]

Christopher Waters made changes - 18/Mar/19 11:51 AM

Link

This issue is FF-depended by ~~DM-18528~~ [ ~~DM-18528~~ ]

Hide

Permalink

Christopher Waters added a comment - 19/Mar/19 2:39 PM

These tests have finally converged with the addition of the `ip_isr/isrMock.py` code to supply "realistic" simulated data to check. Running these tests uncovered some bugs in the ISR code, which has now been corrected.

Show

Christopher Waters added a comment - 19/Mar/19 2:39 PM These tests have finally converged with the addition of the `ip_isr/isrMock.py` code to supply "realistic" simulated data to check. Running these tests uncovered some bugs in the ISR code, which has now been corrected.

Christopher Waters made changes - 19/Mar/19 2:41 PM

Reviewers		John Parejko [ parejkoj ]
Status	In Progress [ 3 ]	In Review [ 10004 ]

Yusra AlSayyad made changes - 08/Apr/19 6:49 PM

Sprint

DRP F18-4, DRP F18-5, DRP F18-6, DRP S19-1, DRP S19-2, DRP S19-3, DRP S19-4 [ 774, 790, 811, 822, 840, 859, 868 ]

DRP F18-4, DRP F18-5, DRP F18-6, DRP S19-1, DRP S19-2, DRP S19-3, DRP S19-4, DRP S19-5 [ 774, 790, 811, 822, 840, 859, 868, 898 ]

Yusra AlSayyad made changes - 05/May/19 10:06 PM

Sprint

DRP F18-4, DRP F18-5, DRP F18-6, DRP S19-1, DRP S19-2, DRP S19-3, DRP S19-4, DRP S19-5 [ 774, 790, 811, 822, 840, 859, 868, 898 ]

DRP F18-4, DRP F18-5, DRP F18-6, DRP S19-1, DRP S19-2, DRP S19-3, DRP S19-4, DRP S19-5, DRP S19-6a [ 774, 790, 811, 822, 840, 859, 868, 898, 915 ]

Hide

Permalink

John Parejko added a comment - 09/May/19 10:50 PM

Please file a ticket describing the missing tests (places where the current test is just "did the Task not raise or return None", etc.), so that we do not forget that some of those tests are not functionality tests. If its possible to list such tests in that ticket, that would be useful.

Show

John Parejko added a comment - 09/May/19 10:50 PM Please file a ticket describing the missing tests (places where the current test is just "did the Task not raise or return None", etc.), so that we do not forget that some of those tests are not functionality tests. If its possible to list such tests in that ticket, that would be useful.

John Parejko made changes - 09/May/19 10:50 PM

Status

In Review [ 10004 ]

Reviewed [ 10101 ]

Christopher Waters made changes - 10/May/19 3:13 AM

Link

This issue is FF-depended by DM-19707 [ DM-19707 ]

Christopher Waters made changes - 10/May/19 6:06 AM

Resolution		Done [ 10000 ]
Status	Reviewed [ 10101 ]	Done [ 10002 ]

People

Assignee:: Christopher Waters

Reporter:: Christopher Waters

Reviewers:: John Parejko

Watchers:: Andrés Alejandro Plazas Malagón, Christopher Waters, John Parejko, Russell Owen, Simon Krughoff, Yusra AlSayyad

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 07/Sep/18 3:58 PM

Updated:: 10/May/19 6:06 AM

Resolved:: 10/May/19 6:06 AM

Jenkins

No builds found.

Data Management

Details

Description

Attachments

Issue Links

Activity

People

Dates

Jenkins