Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15683

Add tests for ip_isr/isrTask

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_isr
    • Labels:
      None
    • Story Points:
      12
    • Epic Link:
    • Sprint:
      DRP F18-4, DRP F18-5, DRP F18-6, DRP S19-1, DRP S19-2, DRP S19-3, DRP S19-4, DRP S19-5, DRP S19-6a
    • Team:
      Data Release Production

      Description

      The current isrTask is poorly covered by the current tests, and there are a number of other ISR functions with no tests.  Fix this.

        Attachments

          Issue Links

          duplicates

          Improvement - An improvement or enhancement to an existing feature or task. DM-1683 Some tests compare local bboxes; why not parent?

          • Won't Fix
          FF-depends on

          Improvement - An improvement or enhancement to an existing feature or task. DM-1448 Move code for mock images into afw so it reusable.

          • Done
          is duplicated by

          Improvement - An improvement or enhancement to an existing feature or task. DM-6161 Add unit test for IsrTask

          • Invalid

          Improvement - An improvement or enhancement to an existing feature or task. DM-9374 Add missing unit tests to ip_isr

          • Invalid
          is FF-depended by

          Improvement - An improvement or enhancement to an existing feature or task. DM-19707 ip_isr tests do not all test functionality

          • To Do

          Improvement - An improvement or enhancement to an existing feature or task. DM-4441 Support multi-mode fringe subtraction

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-18528 ip_isr MeasureCrosstalkTask cannot identify negative crosstalk signals

          • Invalid
          verifies

          Bug - A problem which impairs or prevents the functions of the product. DM-18065 Bad logic in saturation interpolation config options

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            czw Christopher Waters added a comment -

            This ticket will resolve these.

            Show
            czw Christopher Waters added a comment - This ticket will resolve these.
            Hide
            Permalink
            czw Christopher Waters added a comment -

            I'm beginning work on this issue, using the DM-6640 `ip_isr` as a basis, under the assumption that that will be merged first.

            Show
            czw Christopher Waters added a comment - I'm beginning work on this issue, using the DM-6640 `ip_isr` as a basis, under the assumption that that will be merged first.
            Hide
            Permalink
            czw Christopher Waters added a comment -

            These tests have finally converged with the addition of the `ip_isr/isrMock.py` code to supply "realistic" simulated data to check.  Running these tests uncovered some bugs in the ISR code, which has now been corrected.

            Show
            czw Christopher Waters added a comment - These tests have finally converged with the addition of the `ip_isr/isrMock.py` code to supply "realistic" simulated data to check.  Running these tests uncovered some bugs in the ISR code, which has now been corrected.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Please file a ticket describing the missing tests (places where the current test is just "did the Task not raise or return None", etc.), so that we do not forget that some of those tests are not functionality tests. If its possible to list such tests in that ticket, that would be useful.

            Show
            Parejkoj John Parejko added a comment - Please file a ticket describing the missing tests (places where the current test is just "did the Task not raise or return None", etc.), so that we do not forget that some of those tests are not functionality tests. If its possible to list such tests in that ticket, that would be useful.

              People

              Assignee:
              czw Christopher Waters
              Reporter:
              czw Christopher Waters
              Reviewers:
              John Parejko
              Watchers:
              Andrés Alejandro Plazas Malagón, Christopher Waters, John Parejko, Russell Owen, Simon Krughoff, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.