Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15691

The raw_visit table in obs_lsstCam registry is not optimized

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_lsst
    • Labels:
      None

      Description

      As is in obs_lsstCam, the raw_visit table in registry.sqlite3 has the same per-file informarion as the raw table. But it should be just the visit information for optimization in obs_base.

      I think this is to fix config.register.visit in obs_lsstCam config/ingest.py

       

       

        Attachments

          Issue Links

            Activity

            Hide
            hchiang2 Hsin-Fang Chiang added a comment - - edited

            Kian-Tat Lim pointed out that the four columns that should be in `raw_visit` are 'visit', 'filter', 'expTime', 'taiObs', as specified in https://github.com/lsst/obs_base/blob/master/python/lsst/obs/base/mapping.py#L243-L247

            Currently obs_lsstCam has dateObs but not taiObs, so I'm using dateObs for now.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - - edited Kian-Tat Lim pointed out that the four columns that should be in `raw_visit` are 'visit', 'filter', 'expTime', 'taiObs', as specified in https://github.com/lsst/obs_base/blob/master/python/lsst/obs/base/mapping.py#L243-L247 Currently obs_lsstCam has dateObs but not taiObs, so I'm using dateObs for now.
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            I tried ingesting some imsim data with the ticket branch and it looks fine to me. Instead of having one row for each file, this fix means one row for each visit in the raw_visit table in registry.sqlite3.

            Are there other tests I should do?

            Show
            hchiang2 Hsin-Fang Chiang added a comment - I tried ingesting some imsim data with the ticket branch and it looks fine to me. Instead of having one row for each file, this fix means one row for each visit in the raw_visit table in registry.sqlite3. Are there other tests I should do?
            Hide
            rhl Robert Lupton added a comment -

            Looks great

            Show
            rhl Robert Lupton added a comment - Looks great
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Thanks! Merged to master.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Thanks! Merged to master.

              People

              Assignee:
              hchiang2 Hsin-Fang Chiang
              Reporter:
              hchiang2 Hsin-Fang Chiang
              Reviewers:
              Robert Lupton
              Watchers:
              Hsin-Fang Chiang, Kian-Tat Lim, Robert Lupton
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.