Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15762

surface brightness/fluence flags in ExposureInfo and PhotoCalib

    XMLWordPrintable

    Details

    • Type: Story
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: afw

      Description

      Per Jim Bosch's Community post, we should keep track of whether an Exposure is a surface brightness or fluence image (bool in ExposureInfo should be fine), and which of those a PhotoCalib maps from and to (probably a 3-value enum: SB->SB, SB->F, F->F). This ticket is just to add this metadata, we'll make use if it in other tickets, e.g. to ensure than an image input into PhotoCalib.calibrateImage() is of the correct type.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            So you're going to need to put a configuration option in ISR.

            Or in the flat-construction tasks, to be propagated to ISR with the flats.  Haven't thought too deeply about it.

             

            But then what's the point of carrying that configuration option in the Exposure?

            I haven't thought too deeply about this either, yet, but it seems like a pretty important aspect of the image (though I think I'd slightly prefer to attach it to PhotoCalib rather than ExposureInfo directly).  Might mostly be useful for downstream ad-hoc analysis, but I could imagine e.g. asserting that the image is fluence when doing photometry (once we actually make the pipelines do that) or that they're surface-brightness when running background estimation.

             

            Show
            jbosch Jim Bosch added a comment - So you're going to need to put a configuration option in ISR. Or in the flat-construction tasks, to be propagated to ISR with the flats.  Haven't thought too deeply about it.   But then what's the point of carrying that configuration option in the  Exposure ? I haven't thought too deeply about this either, yet, but it seems like a pretty important aspect of the image (though I think I'd slightly prefer to attach it to PhotoCalib rather than ExposureInfo directly).  Might mostly be useful for downstream ad-hoc analysis, but I could imagine e.g. asserting that the image is fluence when doing photometry (once we actually make the pipelines do that) or that they're surface-brightness when running background estimation.  
            Hide
            price Paul Price added a comment -

            Then this really sounds like a knee-jerk reaction that needs to be thought through some more and RFC-ed before implementation.

            Show
            price Paul Price added a comment - Then this really sounds like a knee-jerk reaction that needs to be thought through some more and RFC-ed before implementation.
            Hide
            Parejkoj John Parejko added a comment -

            The reason I want to attach the flag to the Exposure, not PhotoCalib, is because there can be multiple PhotoCalibs (e.g. one from processCcd, one from jointcal), and those may not be directly attached to the Exposure (e.g. the jointcal one lives in a different butler datasetName). Hence the two different flags, one in ExposureInfo, the other in PhotoCalib.

            Show
            Parejkoj John Parejko added a comment - The reason I want to attach the flag to the Exposure, not PhotoCalib, is because there can be multiple PhotoCalibs (e.g. one from processCcd, one from jointcal), and those may not be directly attached to the Exposure (e.g. the jointcal one lives in a different butler datasetName). Hence the two different flags, one in ExposureInfo, the other in PhotoCalib.
            Hide
            erykoff Eli Rykoff added a comment -

            Question of RFC aside, this is definitely a property of the Exposure. And it would be very helpful to indicate if an Exposure is surface brightness or fluence if it could be either.

            Show
            erykoff Eli Rykoff added a comment - Question of RFC aside, this is definitely a property of the Exposure . And it would be very helpful to indicate if an Exposure is surface brightness or fluence if it could be either.
            Hide
            swinbank John Swinbank added a comment -

            Per discussion (John Parejko, Jim Bosch, Eric Bellm, John Swinbank) of 2018-10-30, we agreed that this is a) more complicated than thought, b) not actually necessary to complete DM-11783. Punting it to the future.

            Show
            swinbank John Swinbank added a comment - Per discussion ( John Parejko , Jim Bosch , Eric Bellm , John Swinbank ) of 2018-10-30, we agreed that this is a) more complicated than thought, b) not actually necessary to complete DM-11783 . Punting it to the future.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Eli Rykoff, Jim Bosch, John Parejko, John Swinbank, Merlin Fisher-Levine, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated: