Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15767

Remove pex_policy and Persistable usage from daf_persistence, obs_*, and Filter

    XMLWordPrintable

    Details

    • Story Points:
      6
    • Epic Link:
    • Sprint:
      BG3_F18_09, BG3_F18_10
    • Team:
      Data Release Production

      Description

      This work was started on DM-14504, while trying to make it possible to remove daf.base.Persistable by first removing pex_policy.  I made a lot of progress on that, but the effort stalled out when I discoverd that ctrl_orca and ctrl_execute still use pex_policy, so I've spun off the work I have done one this ticket.  Even if it doesn't remove pex_policy entirely, it'll still be a step in the right direction.

       

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-15593 daf_persistence segfaults on Princeton tiger2 cluster

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-222 Remove most formatter and boost::serialization code

          • Implemented

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-525 Remove pex_policy usage from daf_persistence, afw, and obs_base

          • Implemented
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-16413 Remove more paf files from obs_base

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14504 Remove daf_persistence hooks in PropertySet, PropertyList, and afw objects

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            This ticket is mostly deletions, so hopefully the reviews should be easy.

            Nate Pease [X], please look at:

            Lauren MacArthur, please look at:

            A note for Kian-Tat Lim in particular: I've reverted the removal of DbAuth based on your concern that there might be some usage lurking in untested code; I think it's best to merge the rest of this now and return to that question later.

            Show
            jbosch Jim Bosch added a comment - This ticket is mostly deletions, so hopefully the reviews should be easy. Nate Pease [X] , please look at: daf_base: https://github.com/lsst/daf_base/pull/44 daf_persistence: https://github.com/lsst/daf_persistence/pull/102 obs_base: https://github.com/lsst/obs_base/pull/116 obs_ctio0m9: https://github.com/lsst/obs_ctio0m9/pull/19 Lauren MacArthur , please look at: afw: https://github.com/lsst/afw/pull/404 coadd_utils: https://github.com/lsst/coadd_utils/pull/21 coadd_chisquared: https://github.com/lsst/coadd_chisquared/pull/15 meas_algorithms: https://github.com/lsst/meas_algorithms/pull/141 A note for Kian-Tat Lim in particular: I've reverted the removal of DbAuth based on your concern that there might be some usage lurking in untested code; I think it's best to merge the rest of this now and return to that question later.
            Hide
            Permalink
            npease Nate Pease [X] (Inactive) added a comment -

            I reviewed the files listed for me. I had one comment, otherwise it all looks ok; I'm removing myself from the list of reviewers.

            Show
            npease Nate Pease [X] (Inactive) added a comment - I reviewed the files listed for me. I had one comment, otherwise it all looks ok; I'm removing myself from the list of reviewers.
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            A few comments on the PR. While I don't really know how to test all this, I suppose a Jenkins lsst_distrib + lsst_ci + ci_hsc should be sufficient.

            Show
            lauren Lauren MacArthur added a comment - A few comments on the PR. While I don't really know how to test all this, I suppose a Jenkins lsst_distrib + lsst_ci + ci_hsc should be sufficient.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Lauren MacArthur, I just realized I forgot to create and send to you an ip_diffim PR for this ticket.  Could you take a quick look at that, too, while I kick off another Jenkins run (it also needed to be rebased)?

            Show
            jbosch Jim Bosch added a comment - Lauren MacArthur , I just realized I forgot to create and send to you an ip_diffim PR for this ticket.  Could you take a quick look at that, too, while I kick off another Jenkins run (it also needed to be rebased)?
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            https://github.com/lsst/ip_diffim/pull/103

            Show
            jbosch Jim Bosch added a comment - https://github.com/lsst/ip_diffim/pull/103
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Show
            lauren Lauren MacArthur added a comment -
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Merged to master.  Community post coming momentarily.

            Show
            jbosch Jim Bosch added a comment - Merged to master.  Community post coming momentarily.

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Lauren MacArthur
              Watchers:
              Jim Bosch, Lauren MacArthur, Nate Pease [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.