Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15769

Better error message required for no input data

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_drivers
    • Labels:
      None
    • Team:
      Architecture

      Description

      When running the `construct*.py` scripts, if there is no input data (e.g. when the ingest has failed), the error one gets tends to be a division by zero from the zero-length of the refList. This is more confusing to newbies and people unfamiliar with this part of the stack that one might expect, and is worth fixing I think. A simple check that one isn't operating on no data before going ahead should suffice I think.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          mfisherlevine Merlin Fisher-Levine created issue -
          mfisherlevine Merlin Fisher-Levine made changes -
          Field Original Value New Value
          Risk Score 0
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment -

          Added a couple of error checks.

          Show
          ktl Kian-Tat Lim added a comment - Added a couple of error checks.
          ktl Kian-Tat Lim made changes -
          Reviewers Merlin Fisher-Levine [ mfisherlevine ]
          Status To Do [ 10001 ] In Review [ 10004 ]
          ktl Kian-Tat Lim made changes -
          Assignee Kian-Tat Lim [ ktl ]
          ktl Kian-Tat Lim made changes -
          Team Architecture [ 10304 ]
          Hide
          Permalink
          mfisherlevine Merlin Fisher-Levine added a comment -

          Looks great!

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - Looks great!
          mfisherlevine Merlin Fisher-Levine made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment -

          Passes Jenkins, although likely untested except flake8; merged in f9cb114.

          Show
          ktl Kian-Tat Lim added a comment - Passes Jenkins, although likely untested except flake8; merged in f9cb114.
          ktl Kian-Tat Lim made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]

            People

            Assignee:
            ktl Kian-Tat Lim
            Reporter:
            mfisherlevine Merlin Fisher-Levine
            Reviewers:
            Merlin Fisher-Levine
            Watchers:
            Kian-Tat Lim, Merlin Fisher-Levine
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.