Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1578

Move photocal out of meas_astrom

    Details

    • Story Points:
      2
    • Sprint:
      Science Pipelines DM-W15-4, Science Pipelines DM-S15-1, Science Pipelines DM-S15-3
    • Team:
      Alert Production

      Description

      It is confusing that photocal is in meas_astrom. I assume that is historical. I think it could probably live in pipe_tasks.

        Attachments

          Issue Links

            Activity

            Hide
            rhl Robert Lupton added a comment -

            I'm not sure how to close this (we don't seem to have duplicate)

            Show
            rhl Robert Lupton added a comment - I'm not sure how to close this (we don't seem to have duplicate)
            Hide
            krughoff Simon Krughoff added a comment -

            We can close DM-484 as won't fix and mark this as duplicating that issue.

            Show
            krughoff Simon Krughoff added a comment - We can close DM-484 as won't fix and mark this as duplicating that issue.
            Hide
            rhl Robert Lupton added a comment -

            Well, it isn't "won't fix" it's "duplicate". Should we ask Frossie Economou to add it?

            Show
            rhl Robert Lupton added a comment - Well, it isn't "won't fix" it's "duplicate". Should we ask Frossie Economou to add it?
            Hide
            krughoff Simon Krughoff added a comment -

            What makes sense to me is to close as "won't fix" with resolution as "duplicate." I don't think that's possible, though.

            Show
            krughoff Simon Krughoff added a comment - What makes sense to me is to close as "won't fix" with resolution as "duplicate." I don't think that's possible, though.
            Hide
            frossie Frossie Economou added a comment -

            We should have duplicate. But I don't want to have the discussion in this ticket. I'll take it to the SwDev room.

            Show
            frossie Frossie Economou added a comment - We should have duplicate. But I don't want to have the discussion in this ticket. I'll take it to the SwDev room.
            Hide
            rowen Russell Owen added a comment - - edited

            I did the work on tickets/DM-1578. Affected packages:

            pipe_tasks
            meas_astrom
            obs_sdss
            obs_cfht

            Show
            rowen Russell Owen added a comment - - edited I did the work on tickets/ DM-1578 . Affected packages: pipe_tasks meas_astrom obs_sdss obs_cfht
            Hide
            rowen Russell Owen added a comment - - edited

            I also updated obs_subaru (thanks to Simon for reminding me; it was the one obs_ package I did not have checked out). Unfortunately, due to DM-2792 I cannot test my fix of that package. I merged it anyway, hoping for the best. The other packages have been tested with buildbot.

            Show
            rowen Russell Owen added a comment - - edited I also updated obs_subaru (thanks to Simon for reminding me; it was the one obs_ package I did not have checked out). Unfortunately, due to DM-2792 I cannot test my fix of that package. I merged it anyway, hoping for the best. The other packages have been tested with buildbot.
            Hide
            rowen Russell Owen added a comment -

            Finally, at Simon's suggestion, I removed the tests/astrometry_net_data/photocal/andConfig<n>.py files from pipe_tasks because the pipe_tasks tests didn't need them. tests/astrometry_net_data/photocal/andConfig.py is used, but had one commented-out line that I removed.

            Show
            rowen Russell Owen added a comment - Finally, at Simon's suggestion, I removed the tests/astrometry_net_data/photocal/andConfig<n>.py files from pipe_tasks because the pipe_tasks tests didn't need them. tests/astrometry_net_data/photocal/andConfig.py is used, but had one commented-out line that I removed.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                krughoff Simon Krughoff
                Reviewers:
                Simon Krughoff
                Watchers:
                Frossie Economou, Robert Lupton, Russell Owen, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel