Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1578

Move photocal out of meas_astrom

    XMLWordPrintable

Details

    • 2
    • Science Pipelines DM-W15-4, Science Pipelines DM-S15-1, Science Pipelines DM-S15-3
    • Alert Production

    Description

      It is confusing that photocal is in meas_astrom. I assume that is historical. I think it could probably live in pipe_tasks.

      Attachments

        Issue Links

          Activity

            No builds found.
            krughoff Simon Krughoff (Inactive) created issue -
            krughoff Simon Krughoff (Inactive) made changes -
            Field Original Value New Value
            Epic Link DM-1114 [ 13921 ]

            I'm not sure how to close this (we don't seem to have duplicate)

            rhl Robert Lupton added a comment - I'm not sure how to close this (we don't seem to have duplicate)
            rhl Robert Lupton made changes -
            Link This issue duplicates DM-484 [ DM-484 ]
            krughoff Simon Krughoff (Inactive) made changes -
            Assignee Robert Lupton [ rhl ] Simon Krughoff [ krughoff ]

            We can close DM-484 as won't fix and mark this as duplicating that issue.

            krughoff Simon Krughoff (Inactive) added a comment - We can close DM-484 as won't fix and mark this as duplicating that issue.

            Well, it isn't "won't fix" it's "duplicate". Should we ask frossie to add it?

            rhl Robert Lupton added a comment - Well, it isn't "won't fix" it's "duplicate". Should we ask frossie to add it?

            What makes sense to me is to close as "won't fix" with resolution as "duplicate." I don't think that's possible, though.

            krughoff Simon Krughoff (Inactive) added a comment - What makes sense to me is to close as "won't fix" with resolution as "duplicate." I don't think that's possible, though.

            We should have duplicate. But I don't want to have the discussion in this ticket. I'll take it to the SwDev room.

            frossie Frossie Economou added a comment - We should have duplicate. But I don't want to have the discussion in this ticket. I'll take it to the SwDev room.
            jbosch Jim Bosch made changes -
            Link This issue is duplicated by DM-484 [ DM-484 ]
            krughoff Simon Krughoff (Inactive) made changes -
            Sprint Science Pipelines DM-W15-4 [ 120 ]
            krughoff Simon Krughoff (Inactive) made changes -
            Rank Ranked higher
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-W15-4 [ 120 ] Science Pipelines DM-W15-4, Science Pipelines DM-W15-5 [ 120, 129 ]
            swinbank John Swinbank made changes -
            Rank Ranked higher
            krughoff Simon Krughoff (Inactive) made changes -
            Sprint Science Pipelines DM-W15-4, Science Pipelines DM-W15-5 [ 120, 129 ] Science Pipelines DM-W15-4, Science Pipelines DM-S15-1 [ 120, 140 ]
            krughoff Simon Krughoff (Inactive) made changes -
            Rank Ranked higher
            krughoff Simon Krughoff (Inactive) made changes -
            Rank Ranked lower
            krughoff Simon Krughoff (Inactive) made changes -
            Epic Link DM-1114 [ 13921 ] DM-2026 [ 16157 ]
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-W15-4, Science Pipelines DM-S15-1 [ 120, 140 ] Science Pipelines DM-W15-4, Science Pipelines DM-S15-1, Science Pipelines DM-S15-2 [ 120, 140, 151 ]
            swinbank John Swinbank made changes -
            Rank Ranked higher
            krughoff Simon Krughoff (Inactive) made changes -
            Assignee Simon Krughoff [ krughoff ] Russell Owen [ rowen ]
            krughoff Simon Krughoff (Inactive) made changes -
            Sprint Science Pipelines DM-W15-4, Science Pipelines DM-S15-1, Science Pipelines DM-S15-2 [ 120, 140, 151 ] Science Pipelines DM-W15-4, Science Pipelines DM-S15-1, Science Pipelines DM-S15-3 [ 120, 140, 155 ]
            krughoff Simon Krughoff (Inactive) made changes -
            Rank Ranked lower
            rowen Russell Owen added a comment - - edited

            I did the work on tickets/DM-1578. Affected packages:

            pipe_tasks
            meas_astrom
            obs_sdss
            obs_cfht

            rowen Russell Owen added a comment - - edited I did the work on tickets/ DM-1578 . Affected packages: pipe_tasks meas_astrom obs_sdss obs_cfht
            rowen Russell Owen made changes -
            Reviewers Simon Krughoff [ krughoff ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            rowen Russell Owen added a comment - - edited

            I also updated obs_subaru (thanks to Simon for reminding me; it was the one obs_ package I did not have checked out). Unfortunately, due to DM-2792 I cannot test my fix of that package. I merged it anyway, hoping for the best. The other packages have been tested with buildbot.

            rowen Russell Owen added a comment - - edited I also updated obs_subaru (thanks to Simon for reminding me; it was the one obs_ package I did not have checked out). Unfortunately, due to DM-2792 I cannot test my fix of that package. I merged it anyway, hoping for the best. The other packages have been tested with buildbot.
            rowen Russell Owen added a comment -

            Finally, at Simon's suggestion, I removed the tests/astrometry_net_data/photocal/andConfig<n>.py files from pipe_tasks because the pipe_tasks tests didn't need them. tests/astrometry_net_data/photocal/andConfig.py is used, but had one commented-out line that I removed.

            rowen Russell Owen added a comment - Finally, at Simon's suggestion, I removed the tests/astrometry_net_data/photocal/andConfig<n>.py files from pipe_tasks because the pipe_tasks tests didn't need them. tests/astrometry_net_data/photocal/andConfig.py is used, but had one commented-out line that I removed.
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status In Review [ 10004 ] Done [ 10002 ]
            rowen Russell Owen made changes -
            Link This issue duplicates DM-484 [ DM-484 ]
            jbecla Jacek Becla (Inactive) made changes -
            Team Alert Production [ 10300 ]

            People

              rowen Russell Owen
              krughoff Simon Krughoff (Inactive)
              Simon Krughoff (Inactive)
              Frossie Economou, Robert Lupton, Russell Owen, Simon Krughoff (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.