Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: sconsUtils
-
Labels:
-
Story Points:0.25
-
Epic Link:
-
Sprint:AP F18-4
-
Team:Alert Production
Description
DM-15151 added compilation of pybind11 with hidden symbol visibility, but unfortunately only on macOS. Also add it to linux.
If we are lucky this is a trivial change to sconsUtils. If we are unlucky then that trivial change will break the build on linux.
Attachments
Issue Links
- relates to
-
DM-15151 Set symbol visibility to hidden in pybind11 wrappers
- Done
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Risk Score | 0 |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Reviewers | Jim Bosch [ jbosch ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
| Description |
If we are lucky this is a trivial to sconsUtils. If we are unlucky then that trivial change will break the build on linux. |
If we are lucky this is a trivial change to {{sconsUtils}}. If we are unlucky then that trivial change will break the build on linux. |
Looks good! I have not done a local test, but I'd be happy to poke at the Jenkins build logs if you can point me at the Jenkins run; I bet we can verify that they're gone that way.
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
The Jenkins link in my previous comment points to the appropriate Jenkins run. And I think you are right – it was easy to find the afw build log in Artifacts and I just see one warning, and I'm pretty sure it's been with us for awhile. No symbol visibility warnings.
Thank you for the speedy review and the helpful suggestion for looking at the linux build logs.
I could not find artifacts from the macOS build, but the change should not have affected macOS.
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
If you are willing, please build a package with this and make sure the warnings have gone away.
It has passed Jenkins for linux (including ci_hsc) and the change should not be meaningful on macOS, so I think it is ready to review.