Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15790

Compile pybind11 with hidden symbol visibility on linux

    XMLWordPrintable

Details

    • 0.25
    • AP F18-4
    • Alert Production

    Description

      DM-15151 added compilation of pybind11 with hidden symbol visibility, but unfortunately only on macOS. Also add it to linux.

      If we are lucky this is a trivial change to sconsUtils. If we are unlucky then that trivial change will break the build on linux.

      Attachments

        Issue Links

          Activity

            rowen Russell Owen added a comment - - edited

            If you are willing, please build a package with this and make sure the warnings have gone away.

            It has passed Jenkins for linux (including ci_hsc) and the change should not be meaningful on macOS, so I think it is ready to review.

            rowen Russell Owen added a comment - - edited If you are willing, please build a package with this and make sure the warnings have gone away. It has passed Jenkins for linux (including ci_hsc) and the change should not be meaningful on macOS, so I think it is ready to review.
            jbosch Jim Bosch added a comment -

            Looks good!  I have not done a local test, but I'd be happy to poke at the Jenkins build logs if you can point me at the Jenkins run; I bet we can verify that they're gone that way.

            jbosch Jim Bosch added a comment - Looks good!  I have not done a local test, but I'd be happy to poke at the Jenkins build logs if you can point me at the Jenkins run; I bet we can verify that they're gone that way.
            rowen Russell Owen added a comment - - edited

            The Jenkins link in my previous comment points to the appropriate Jenkins run. And I think you are right – it was easy to find the afw build log in Artifacts and I just see one warning, and I'm pretty sure it's been with us for awhile. No symbol visibility warnings.

            rowen Russell Owen added a comment - - edited The Jenkins link in my previous comment points to the appropriate Jenkins run. And I think you are right – it was easy to find the afw build log in Artifacts and I just see one warning, and I'm pretty sure it's been with us for awhile. No symbol visibility warnings.
            rowen Russell Owen added a comment -

            Thank you for the speedy review and the helpful suggestion for looking at the linux build logs.

            I could not find artifacts from the macOS build, but the change should not have affected macOS.

            rowen Russell Owen added a comment - Thank you for the speedy review and the helpful suggestion for looking at the linux build logs. I could not find artifacts from the macOS build, but the change should not have affected macOS.
            jbosch Jim Bosch added a comment -

            Yup, don't know how I missed that link before, but I agree it's all clear.

            jbosch Jim Bosch added a comment - Yup, don't know how I missed that link before, but I agree it's all clear.

            People

              rowen Russell Owen
              rowen Russell Owen
              Jim Bosch
              Jim Bosch, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.