Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: display_firefly
-
Labels:None
-
Story Points:14
-
Epic Link:
-
Sprint:SUIT Sprint 2018-10, SUIT Sprint 2018-11
-
Team:Science User Interface
Description
Implement functionality as part of the display_firefly backend to enable drawing footprints on an image, a custom method of the Display object.
The overlayFootprints method will take the SourceCatalog instance as a required arguments, and will upload a table object that Firefly will understand to contain LSST detection footprints for drawing. Functionality will be added for setting the layout to place the image at upper left and the table at bottom in the Firefly display, similar to IRSA's Gator layout.
The example notebook is https://github.com/lsst/display_firefly/blob/master/examples/HSC-Footprints.ipynb
Attachments
Issue Links
- has to be finished together with
-
- Done
- relates to
-
DM-16451 Fix color parameter names for overlaying footprints
- Done
-
- Done
-
- Won't Fix
-
DM-16441 Speed up creation of footprints table for Firefly
- Done
-
- Done
- mentioned in
-
Page Loading...
Activity
Looks good, to the extend I can judge given my lack of knowledge of VOTable and Firefly protocols; my comments are mostly style issues that are mostly fixable with some linting.
It'd definitely be good to update the example notebook after this functionality is live on lsp-dev to reflect that environment in terms of data locations and Firefly server access.
Tested in the lsst-lspdev environment with Firefly server url as http://lsst-demo.ncsa.illinois.edu/firefly
In the future we will want to make use of slots_centroid_x and slots_centroid_y as noted on the review of the pull request.
In the lsst-lspdev environment, the creation of the VOTable for Firefly can be quite slow. DM-16441 has been filed to address this aspect of performance.
David Shupe
added a comment - Tested in the lsst-lspdev environment with Firefly server url as http://lsst-demo.ncsa.illinois.edu/firefly
In the future we will want to make use of slots_centroid_x and slots_centroid_y as noted on the review of the pull request.
In the lsst-lspdev environment, the creation of the VOTable for Firefly can be quite slow. DM-16441 has been filed to address this aspect of performance. 
There is a large function to convert the afwTable.SourceCatalog into an astropy.vo.VOTableFile that Firefly uses draw the detection footprints and link them to the table. An example notebook has been provided.
Final review probably ought to wait until we have the updated Firefly server and firefly_client available for testing from the lsst-lspdev science platform.