Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15840

Try to fix protected dtor support in pybind11 upstream

    Details

    • Type: Story
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: None
    • Templates:
    • Story Points:
      8

      Description

      pybind11 upstream only supports non-public dtors via a unique_ptr no-op deleter.  That doesn't work for types that have a protected destructor because they're used as nonpolymorphic base classes (e.g. ImageBaseFitsReader), because pybind11 also requires that subclasses use the same holder type as their base class.

      pybind11 really shouldn't be requiring any holder type for classes that are never instantiated.

      Something at least closely related has been reported as https://github.com/pybind/pybind11/issues/1178.

        Attachments

          Container Issues

            Activity

              People

              • Assignee:
                jbosch Jim Bosch
                Reporter:
                jbosch Jim Bosch
                Watchers:
                Jim Bosch
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Summary Panel