Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15851

sconsUtils does not reliably remove the .failed file

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: sconsUtils
    • Labels:
      None
    • Sprint:
      Arch 2018-10-01, Arch 2018-10-08, Arch 2018-10-15
    • Team:
      Architecture

      Description

      Following the merge of DM-11693, we are discovering that sconsUtils is no longer deleting the .xml.failed file when it is re-run. The "running tests twice as part of install" problem has been fixed but normal developer workflow of typing scons, getting a failure, fixing the failure, typing scons again, is now broken. This is because the second time you type scons the .failed file is not removed, so pytest now passes but sconsUtils sees the .failed file and stops everything and reports that there was a problem (when there wasn't). Being forced to manually remove the .failed file is annoying.

        Attachments

          Issue Links

          is triggered by

          Bug - A problem which impairs or prevents the functions of the product. DM-11693 Rebuild runs pytest tests twice for every product

          • Done

            Activity

            Ascending order - Click to sort in descending order
            6 older comments
            Hide
            Permalink
            bvan Brian Van Klaveren added a comment -

            I have a fix in, this should obliterate files when you are not performing an install, and preserve the files if you are doing an install

            Show
            bvan Brian Van Klaveren added a comment - I have a fix in, this should obliterate files when you are not performing an install, and preserve the files if you are doing an install
            Hide
            Permalink
            bvan Brian Van Klaveren added a comment -

            Jenkins job: 28745, passed linux so far, still waiting on Mac.

            I tried testing this locally with a test case that fails and it seems to be working as intended.

            Show
            bvan Brian Van Klaveren added a comment - Jenkins job: 28745, passed linux so far, still waiting on Mac. I tried testing this locally with a test case that fails and it seems to be working as intended.
            Hide
            Permalink
            bvan Brian Van Klaveren added a comment -

            Tim Jenness I think this should be fixed adequately. I ran a CI 10/12/2018 (job #28844) and it seems to be behaving as normal when running scons directly.

            Show
            bvan Brian Van Klaveren added a comment - Tim Jenness I think this should be fixed adequately. I ran a CI 10/12/2018 (job #28844) and it seems to be behaving as normal when running scons directly.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I can confirm that this fixes the problem for me.

            Show
            tjenness Tim Jenness added a comment - I can confirm that this fixes the problem for me.
            Hide
            Permalink
            bvan Brian Van Klaveren added a comment -

            Merged.

            Show
            bvan Brian Van Klaveren added a comment - Merged.

              People

              Assignee:
              bvan Brian Van Klaveren
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Tim Jenness
              Watchers:
              Brian Van Klaveren, Eli Rykoff, Kian-Tat Lim, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.