Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-15928

Propagate DIASource flags into PPDB

    Details

      Description

      Currently flags are not being copied from the DIASource catalogs into the PPDB. This ticket is to do so.

        Attachments

          Activity

          Hide
          swinbank John Swinbank added a comment - - edited

          At our (Chris Morrison, Eric Bellm, John Swinbank) meeting of 2018-10-30, we discussed this ticket. We concluded that it was possible that we'd be able to address it in the November 2018 sprint (effectively, after DM-14857 and DM-15588 are done, Chris Morrison is free to chose whether he thinks this or DM-15795 will be more fun to work on first). Given that, I'm pulling it into the sprint, but we can always remove it later.

          We also discussed implementation. Chris is keen to take this opportunity to write flags directly into bit-packed fields. I am happy with that approach, as long as the bit-packing machinery doesn't add substantially to the implementation time (this is currently a 6 SP ticket; if writing machinery makes it balloon beyond that, we should stop), and as long as there are appropriate abstractions to shield algorithmic code from having to do bitfield manipulations directly (ie, user-level code should always be able to ask for a flag value by name, not to retrieve a bitfield and have to unpack it).

          Show
          swinbank John Swinbank added a comment - - edited At our ( Chris Morrison , Eric Bellm , John Swinbank ) meeting of 2018-10-30, we discussed this ticket. We concluded that it was possible that we'd be able to address it in the November 2018 sprint (effectively, after DM-14857 and DM-15588 are done, Chris Morrison is free to chose whether he thinks this or DM-15795 will be more fun to work on first). Given that, I'm pulling it into the sprint, but we can always remove it later. We also discussed implementation. Chris is keen to take this opportunity to write flags directly into bit-packed fields. I am happy with that approach, as long as the bit-packing machinery doesn't add substantially to the implementation time (this is currently a 6 SP ticket; if writing machinery makes it balloon beyond that, we should stop), and as long as there are appropriate abstractions to shield algorithmic code from having to do bitfield manipulations directly (ie, user-level code should always be able to ask for a flag value by name, not to retrieve a bitfield and have to unpack it).
          Hide
          cmorrison Chris Morrison added a comment -

          Talked with Eric Bellm today and discussed adding a simple value to put into the DiaObject that is simply a test for "if any flag is set in the DiaSources that make up this DiaObject". 

          Show
          cmorrison Chris Morrison added a comment - Talked with Eric Bellm today and discussed adding a simple value to put into the DiaObject that is simply a test for "if any flag is set in the DiaSources that make up this DiaObject". 
          Show
          cmorrison Chris Morrison added a comment - Jenkins:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29121/pipeline
          Hide
          ebellm Eric Bellm added a comment -

          A couple of small comments on github.

          Show
          ebellm Eric Bellm added a comment - A couple of small comments on github.
          Show
          cmorrison Chris Morrison added a comment - Jenkins after review:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29145/pipeline

            People

            • Assignee:
              cmorrison Chris Morrison
              Reporter:
              ebellm Eric Bellm
              Reviewers:
              Eric Bellm
              Watchers:
              Chris Morrison, Eric Bellm, John Swinbank
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel